fix: support single http-get urls, close #209

Author: bahmutov

.travis.yml

@@ -15,6 +15,8 @@ script:
   - npm run demo5
   - npm run demo6
   - npm run demo7
+  # hmm why are some demos skipped?
+  - npm run demo11
   - START_SERVER_AND_TEST_INSECURE=1 npm run demo9
   - npm run demo-cross-env
   - npm run demo-commands

src/utils-spec.js

@@ -83,6 +83,22 @@ describe('utils', () => {
       la(isUrlOrPort('http://foo.com'))
       la(isUrlOrPort('http://foo.com/bar/baz.html'))
       la(isUrlOrPort('http://localhost:6000'))
+      la(isUrlOrPort('https://google.com'))
+    })
+
+    it('allows url with http-get', () => {
+      la(isUrlOrPort('http-get://localhost'))
+      la(isUrlOrPort('http-get://foo.com'))
+      la(isUrlOrPort('http-get://foo.com/bar/baz.html'))
+      la(isUrlOrPort('http-get://localhost:6000'))
+    })
+
+    it('allows url with https-head', () => {
+      la(isUrlOrPort('https-head://localhost:6000'))
+    })
+
+    it('allows url with https-options', () => {
+      la(isUrlOrPort('https-head://foo'))
     })
 
     it('allows port number or string', () => {

src/utils.js

@@ -73,13 +73,21 @@ const isPackageScriptName = command => {
   return Boolean(packageJson.scripts[command])
 }
 
+const isWaitOnUrl = s => /^https?-(?:get|head|options)/.test(s)
+
 const isUrlOrPort = input => {
   const str = is.string(input) ? input.split('|') : [input]
 
   return str.every(s => {
     if (is.url(s)) {
       return s
     }
+    // wait-on allows specifying HTTP verb to use instead of default HEAD
+    // and the format then is like "http-get://domain.com" to use GET
+    if (isWaitOnUrl(s)) {
+      return s
+    }
+
     if (is.number(s)) {
       return is.port(s)
     }