Don't unregister 'go' and 'process' collectors

njam · njam · commit 728722b1dfea · 2018-02-21T15:03:07.000+01:00
Might be useful for someone. Via prometheus/docs#980 (review)
diff --git a/exporter.go b/exporter.go
@@ -100,8 +100,6 @@ func (e *Exporter) Run() error {
 	if err := prometheus.Register(c); err != nil {
 		return errors.Wrap(err, "failed to register metrics")
 	}
-	prometheus.Unregister(prometheus.NewProcessCollector(os.Getpid(), ""))
-	prometheus.Unregister(prometheus.NewGoCollector())
 
 	http.HandleFunc("/healthz", e.healthz)
 	http.Handle("/metrics", promhttp.Handler())

Original file line number	Diff line number	Diff line change
`@@ -100,8 +100,6 @@ func (e *Exporter) Run() error {`
`100`	`100`	`if err := prometheus.Register(c); err != nil {`
`101`	`101`	`return errors.Wrap(err, "failed to register metrics")`
`102`	`102`	`}`
`103`		`- prometheus.Unregister(prometheus.NewProcessCollector(os.Getpid(), ""))`
`104`		`- prometheus.Unregister(prometheus.NewGoCollector())`
`105`	`103`
`106`	`104`	`http.HandleFunc("/healthz", e.healthz)`
`107`	`105`	`http.Handle("/metrics", promhttp.Handler())`