Rename "scrape_failures" to "scrape_failures_total"

andrewhowdencom · andrewhowdencom · commit c67d95d9ccc5 · 2017-07-26T12:52:45.000+02:00
This metric expresses a sum / accumulating unit, and should thusly be suffixed with total[1] https://prometheus.io/docs/practices/naming/#metric-names
diff --git a/collector.go b/collector.go
@@ -57,7 +57,7 @@ func (e *Exporter) newCollector() *collector {
 		maxActiveProcesses: newFuncMetric("active_max_processes", "Maximum active process count"),
 		maxChildrenReached: newFuncMetric("max_children_reached_total", "Number of times the process limit has been reached"),
 		slowRequests:       newFuncMetric("slow_requests_total", "Number of requests that exceed request_slowlog_timeout"),
-		scrapeFailures:     newFuncMetric("scrape_failures", "Number of errors while scraping php_fpm"),
+		scrapeFailures:     newFuncMetric("scrape_failures_total", "Number of errors while scraping php_fpm"),
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ func (e Exporter) newCollector() collector {`
`57`	`57`	`maxActiveProcesses: newFuncMetric("active_max_processes", "Maximum active process count"),`
`58`	`58`	`maxChildrenReached: newFuncMetric("max_children_reached_total", "Number of times the process limit has been reached"),`
`59`	`59`	`slowRequests: newFuncMetric("slow_requests_total", "Number of requests that exceed request_slowlog_timeout"),`
`60`		`- scrapeFailures: newFuncMetric("scrape_failures", "Number of errors while scraping php_fpm"),`
	`60`	`+ scrapeFailures: newFuncMetric("scrape_failures_total", "Number of errors while scraping php_fpm"),`
`61`	`61`	`}`
`62`	`62`	`}`
`63`	`63`