Deployment preparation: Protocol Fee Helper V2 (#309)

Author: EndymionJkb

README.md

@@ -132,7 +132,6 @@ Returns an object with all contracts from a deployment and their addresses.
 | V3 Stable Surge Hook (V2)                              | [`20250403-v3-stable-surge-hook-v2`](./v3/tasks/20250403-v3-stable-surge-hook-v2)                       |
 | V3 Vault Explorer V2                                   | [`20250407-v3-vault-explorer-v2`](./v3/tasks/20250407-v3-vault-explorer-v2)                             |
 | V3 Wrapped BPT Factory                                 | [`20250418-v3-wrapped-bpt`](./v3/tasks/20250418-v3-wrapped-bpt)                                         |
-| V3 Protocol Fee Helper                                 | [`20250430-v3-protocol-fee-helper`](./v3/tasks/20250430-v3-protocol-fee-helper)                         |
 | V3 Protocol Fee Percentages Provider                   | [`20250502-v3-fee-percentages-provider`](./v3/tasks/20250502-v3-fee-percentages-provider)               |
 | V3 Protocol Fee Sweeper (V2)                           | [`20250503-v3-protocol-fee-sweeper-v2`](./v3/tasks/20250503-v3-protocol-fee-sweeper-v2)                 |
 | V3 Aggregator Batch Router                             | [`20250507-v3-aggregator-batch-router`](./v3/tasks/20250507-v3-aggregator-batch-router)                 |
@@ -143,6 +142,7 @@ Returns an object with all contracts from a deployment and their addresses.
 | V3 Weighted LP Oracle                                  | [`20250814-v3-weighted-pool-oracle`](./v3/tasks/20250814-v3-weighted-pool-oracle)                       |
 | V3 Stable LP Oracle                                    | [`20250815-v3-stable-pool-oracle`](./v3/tasks/20250815-v3-stable-pool-oracle)                           |
 | V3 HyperEVM Rate Provider                              | [`20250828-v3-hyperevm-rate-provider`](./v3/tasks/20250828-v3-hyperevm-rate-provider)                   |
+| V3 Protocol Fee Helper (V2)                            | [`20250919-v3-protocol-fee-helper-v2`](./v3/tasks/20250919-v3-protocol-fee-helper-v2)                   |
 | V3 Pool Pause Helper (V2)                              | [`20250919-v3-pool-pause-helper-v2`](./v3/tasks/20250919-v3-pool-pause-helper-v2)                       |
 | V3 Pool Swap Fee Helper (V2)                           | [`20250919-v3-pool-swap-fee-helper-v2`](./v3/tasks/20250919-v3-pool-swap-fee-helper-v2)                 |
 | Pool Swap Fee Helper                                   | [`20250919-pool-swap-fee-helper`](./v2/tasks/20250919-pool-swap-fee-helper)                             |
@@ -261,6 +261,7 @@ Go to each deprecated deployment's readme file to learn more about why it is dep
 | V3 Stable Pool V2                                   | [`20250324-v3-stable-pool-v2`](./v3/deprecated/20250324-v3-stable-pool-v2)                               |
 | V3 Stable Surge Pool (V2)                           | [`20250404-v3-stable-surge-pool-factory-v2`](./v3/deprecated/20250404-v3-stable-surge-pool-factory-v2)   |
 | V3 ReClamm Pool                                     | [`20250409-v3-reclamm-pool`](./v3/deprecated/20250409-v3-reclamm-pool)                                   |
+| V3 Protocol Fee Helper                              | [`20250430-v3-protocol-fee-helper`](./v3/deprecated/20250430-v3-protocol-fee-helper)                     |
 | V3 Pool Pause Helper                                | [`20250430-v3-pool-pause-helper`](./v3/deprecated/20250430-v3-pool-pause-helper)                         |
 | V3 Pool Swap Fee Helper                             | [`20250430-v3-pool-swap-fee-helper`](./v3/deprecated/20250430-v3-pool-swap-fee-helper)                   |
 | V3 ERC4626 Cow Swap Fee Burner                      | [`20250507-v3-erc4626-cow-swap-fee-burner`](./v3/deprecated/20250507-v3-erc4626-cow-swap-fee-burner)     |

…e-helper/artifact/ProtocolFeeHelper.json …e-helper/artifact/ProtocolFeeHelper.jsonv3/tasks/20250430-v3-protocol-fee-helper/artifact/ProtocolFeeHelper.json renamed to v3/deprecated/20250430-v3-protocol-fee-helper/artifact/ProtocolFeeHelper.json v3/tasks/20250430-v3-protocol-fee-helper/artifact/ProtocolFeeHelper.json renamed to v3/deprecated/20250430-v3-protocol-fee-helper/artifact/ProtocolFeeHelper.json

@@ -1,5 +1,9 @@
 # 2025-04-30 - V3 Protocol Fee Helper
 
+> ⚠️ **DEPRECATED: do not use** ⚠️
+>
+> This version was superseded by [`ProtocolFeeHelper` V2](../../tasks/20250919-v3-protocol-fee-helper-v2/), which generalizes the implementation to allow multiple, transferrable allowlists. This allows multiple partners to use the same contract, and eases the burden on governance.
+
 The Protocol Fee Helper contract enables granular control over the power to set protocol swap and yield fees on pools. It maintains a set of registered pools whose fees can be set by authorized accounts. Governance must first grant this contract permission to set protocol fees, then add a set of pools, and finally grant permission to call the fee setters on the helper contract.
 
 ## Useful Files

…helper/build-info/ProtocolFeeHelper.json …helper/build-info/ProtocolFeeHelper.jsonv3/tasks/20250430-v3-protocol-fee-helper/build-info/ProtocolFeeHelper.json renamed to v3/deprecated/20250430-v3-protocol-fee-helper/build-info/ProtocolFeeHelper.json v3/tasks/20250430-v3-protocol-fee-helper/build-info/ProtocolFeeHelper.json renamed to v3/deprecated/20250430-v3-protocol-fee-helper/build-info/ProtocolFeeHelper.json

@@ -6,7 +6,7 @@ import { describeForkTest, getForkedNetwork, Task, TaskMode, impersonate, getSig
 import { actionId } from '@helpers/models/misc/actions';
 import { SignerWithAddress } from '@nomiclabs/hardhat-ethers/signers';
 
-describeForkTest('V3-ProtocolFeeHelper', 'mainnet', 22348940, function () {
+describeForkTest.skip('V3-ProtocolFeeHelper', 'mainnet', 22348940, function () {
   const TASK_NAME = '20250430-v3-protocol-fee-helper';
   const CONTRACT_NAME = 'ProtocolFeeHelper';