TypeError: Right-hand side of 'instanceof' is not callable in is-binary.js node 20+ sails-hook-sockets

[tyeltsing]

Summary
When running a project on Node.js 24, the application crashes with a TypeError during binary data checks in socket.io-parser. This happens because the check for withNativeFile (and potentially withNativeBlob) assumes that if the global exists, it is a valid constructor. If these globals are set to undefined (common in some legacy compatibility layers or strict environment sanitization), the instanceof check fails.

...\node_modules\socket.io-parser\build\cjs\is-binary.js:26
(withNativeFile && obj instanceof File));
^

TypeError: Right-hand side of 'instanceof' is not callable
at isBinary (...\node_modules\socket.io-parser\build\cjs\is-binary.js:26:32)

Suggested Fix
Update the is-binary logic to verify the type of the constructor before performing the instanceof check:

function isBinary(obj) {
return (
(withNativeArrayBuffer && typeof ArrayBuffer === 'function' && (obj instanceof ArrayBuffer || isView(obj))) ||
(withNativeBlob && typeof Blob === 'function' && obj instanceof Blob ) ||
(withNativeFile && typeof File === 'function' && obj instanceof File)
);
}

[sailsbot]

@tyeltsing Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

• look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
• tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
• make sure you've provided clear instructions on how to reproduce the bug from a clean install.
• double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
• read the code of conduct.
• if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.