lint: swap to biomejs

balloman · balloman · commit b5c242fee0a6 · 2024-11-09T18:21:54.000-08:00
diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml
@@ -6,27 +6,24 @@ on:
 
 jobs:
   lint:
-   name: Lint
-   runs-on: ubuntu-latest
+    name: Lint
+    runs-on: ubuntu-latest
 
-   steps:
-     - name: Check out Git repository
-       uses: actions/checkout@v4
+    steps:
+      - name: Check out Git repository
+        uses: actions/checkout@v4
 
-     - name: Setup Node
-       uses: actions/setup-node@v4
-       with:
-         node-version: 18.x
-         cache: "yarn"
-    
-     - name: Install Node.js Dependencies
-       run: yarn install --frozen-lockfile
+      - name: Setup Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: 18.x
+          cache: "yarn"
 
-     - name: Install Example Dependencies
-       run: yarn --cwd example install --frozen-lockfile
+      - name: Install Node.js Dependencies
+        run: yarn install --frozen-lockfile
 
-     - name: Run ESLint
-       run: yarn lint
+      - name: Install Example Dependencies
+        run: yarn --cwd example install --frozen-lockfile
 
-     - name: Run Prettier
-       run: yarn prettier:check
+      - name: Run Biome
+        run: yarn lint
diff --git a/.npmignore b/.npmignore
@@ -11,4 +11,5 @@ __tests__
 /example/
 .gitignore
 .eslintrc.js
-.prettier*
+.prettier*
+biome.json
diff --git a/.prettierignore b/.prettierignore
diff --git a/.prettierrc b/.prettierrc
diff --git a/biome.json b/biome.json
@@ -0,0 +1,40 @@
+{
+  "$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
+  "vcs": {
+    "enabled": false,
+    "clientKind": "git",
+    "useIgnoreFile": false
+  },
+  "files": {
+    "ignoreUnknown": false,
+    "ignore": [
+      "**/android/*",
+      "**/build/*",
+      "**/ios/*",
+      "**/node_modules/*",
+      "**/*.config.js",
+      "**/.expo/*",
+      "**/*.config.mjs",
+      "**/.vscode/*",
+      "**/*.plugin.js"
+    ]
+  },
+  "formatter": {
+    "enabled": true,
+    "indentStyle": "space"
+  },
+  "organizeImports": {
+    "enabled": true
+  },
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": true
+    }
+  },
+  "javascript": {
+    "formatter": {
+      "quoteStyle": "double"
+    }
+  }
+}
diff --git a/eslint.config.mjs b/eslint.config.mjs
diff --git a/example/App.tsx b/example/App.tsx
@@ -1,5 +1,5 @@
 import {
-  MapFunctions,
+  type MapFunctions,
   MapView,
   MarkerView,
   setApiKey,
@@ -10,6 +10,7 @@ import { Button, StyleSheet, Text, View } from "react-native";
 
 import styleJson from "./style.json";
 
+// biome-ignore lint/style/noNonNullAssertion: If the API key is not set, the app will crash
 setApiKey(process.env.EXPO_PUBLIC_API_KEY!);
 
 export default function App() {
@@ -22,7 +23,7 @@ export default function App() {
       .then(({ status }) => {
         setStatus(status);
       })
-      .catch(e => {
+      .catch((e) => {
         if (e instanceof TypeError) {
           return;
         }
@@ -36,7 +37,7 @@ export default function App() {
         .then(({ status }) => {
           setStatus(status);
         })
-        .catch(e => {
+        .catch((e) => {
           console.log("error", e);
         });
     }
diff --git a/example/app.config.ts b/example/app.config.ts
@@ -1,4 +1,4 @@
-import { ConfigContext, ExpoConfig } from "@expo/config";
+import type { ConfigContext, ExpoConfig } from "@expo/config";
 
 export default ({ config }: ConfigContext): ExpoConfig => ({
   ...config,
diff --git a/example/tsconfig.json b/example/tsconfig.json
@@ -5,6 +5,7 @@
     "paths": {
       "@balloman/expo-google-maps": ["../src/index"],
       "@balloman/expo-google-maps/*": ["../src/*"]
-    }
+    },
+    "resolveJsonModule": true
   }
 }
diff --git a/package.json b/package.json
@@ -7,9 +7,7 @@
   "scripts": {
     "build": "expo-module build",
     "clean": "expo-module clean",
-    "lint": "eslint .",
-    "format": "prettier --write .",
-    "prettier:check": "prettier --check .",
+    "lint": "biome check",
     "test": "expo-module test",
     "prepublishOnly": "expo-module prepublishOnly",
     "expo-module": "expo-module",
@@ -34,21 +32,14 @@
   "homepage": "https://github.com/balloman/expo-google-maps#readme",
   "dependencies": {},
   "devDependencies": {
+    "@biomejs/biome": "1.9.4",
     "@changesets/changelog-github": "^0.5.0",
     "@changesets/cli": "^2.27.1",
-    "@eslint/eslintrc": "^3.1.0",
-    "@eslint/js": "^9.14.0",
-    "@trivago/prettier-plugin-sort-imports": "^4.3.0",
-    "@types/eslint__js": "^8.42.3",
     "@types/react": "^18.2.55",
     "@types/react-native": "^0.73.0",
-    "eslint": "^9.14.0",
-    "eslint-config-prettier": "^9.1.0",
     "expo-module-scripts": "^3.4.1",
     "expo-modules-core": "^1.12.26",
-    "prettier": "^3.2.5",
-    "typescript": "^5.6.3",
-    "typescript-eslint": "^8.13.0"
+    "typescript": "^5.6.3"
   },
   "peerDependencies": {
     "expo": "*",
diff --git a/plugin/src/index.ts b/plugin/src/index.ts
@@ -1,14 +1,15 @@
 import {
   AndroidConfig,
-  ConfigPlugin,
+  type ConfigPlugin,
   withAndroidManifest,
 } from "@expo/config-plugins";
 
 const withAndroidApiKey: ConfigPlugin<{ androidApiKey: string }> = (
   config,
   { androidApiKey },
 ) => {
-  config = withAndroidManifest(config, config => {
+  // biome-ignore lint/style/noParameterAssign: This is a plugin
+  config = withAndroidManifest(config, (config) => {
     const mainApplication = AndroidConfig.Manifest.getMainApplicationOrThrow(
       config.modResults,
     );
diff --git a/src/MapView.tsx b/src/MapView.tsx
@@ -1,8 +1,8 @@
 import { requireNativeViewManager } from "expo-modules-core";
-import * as React from "react";
-import { ViewProps } from "react-native";
+import type * as React from "react";
+import type { ViewProps } from "react-native";
 
-import {
+import type {
   AnimationOptions,
   Camera,
   FitToBoundsOptions,
diff --git a/src/MarkerView.tsx b/src/MarkerView.tsx
@@ -1,8 +1,8 @@
 import { requireNativeViewManager } from "expo-modules-core";
-import * as React from "react";
+import type * as React from "react";
 import { View } from "react-native";
 
-import { Coordinate } from "./ExpoGoogleMaps.types";
+import type { Coordinate } from "./ExpoGoogleMaps.types";
 
 export type Marker = {
   /** The position of the marker */
diff --git a/src/index.ts b/src/index.ts
@@ -1,15 +1,15 @@
 /* eslint-disable @typescript-eslint/no-unsafe-member-access */
+
 /* eslint-disable @typescript-eslint/no-unsafe-call */
+
 /* eslint-disable @typescript-eslint/no-unsafe-argument */
 import { EventEmitter } from "expo-modules-core";
 
 import ExpoGoogleMapsModule from "./ExpoGoogleMapsModule";
 
-const emitter = new EventEmitter(
-  ExpoGoogleMapsModule,
-);
+const emitter = new EventEmitter(ExpoGoogleMapsModule);
 
-emitter.addListener("log", event => {
+emitter.addListener("log", (event) => {
   console.log(event);
 });
 
diff --git a/tsconfig.json b/tsconfig.json
@@ -2,7 +2,8 @@
 {
   "extends": "expo-module-scripts/tsconfig.base",
   "compilerOptions": {
-    "outDir": "./build"
+    "outDir": "./build",
+    "resolveJsonModule": true
   },
   "include": ["./src"],
   "exclude": ["**/__mocks__/*", "**/__tests__/*"]
diff --git a/yarn.lock b/yarn.lock
@@ -1957,6 +1957,60 @@
     "@babel/helper-validator-identifier" "^7.22.20"
     to-fast-properties "^2.0.0"
 
+"@biomejs/biome@1.9.4":
+  version "1.9.4"
+  resolved "https://registry.yarnpkg.com/@biomejs/biome/-/biome-1.9.4.tgz#89766281cbc3a0aae865a7ff13d6aaffea2842bf"
+  integrity sha512-1rkd7G70+o9KkTn5KLmDYXihGoTaIGO9PIIN2ZB7UJxFrWw04CZHPYiMRjYsaDvVV7hP1dYNRLxSANLaBFGpog==
+  optionalDependencies:
+    "@biomejs/cli-darwin-arm64" "1.9.4"
+    "@biomejs/cli-darwin-x64" "1.9.4"
+    "@biomejs/cli-linux-arm64" "1.9.4"
+    "@biomejs/cli-linux-arm64-musl" "1.9.4"
+    "@biomejs/cli-linux-x64" "1.9.4"
+    "@biomejs/cli-linux-x64-musl" "1.9.4"
+    "@biomejs/cli-win32-arm64" "1.9.4"
+    "@biomejs/cli-win32-x64" "1.9.4"
+
+"@biomejs/cli-darwin-arm64@1.9.4":
+  version "1.9.4"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-darwin-arm64/-/cli-darwin-arm64-1.9.4.tgz#dfa376d23a54a2d8f17133c92f23c1bf2e62509f"
+  integrity sha512-bFBsPWrNvkdKrNCYeAp+xo2HecOGPAy9WyNyB/jKnnedgzl4W4Hb9ZMzYNbf8dMCGmUdSavlYHiR01QaYR58cw==
+
+"@biomejs/cli-darwin-x64@1.9.4":
+  version "1.9.4"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-darwin-x64/-/cli-darwin-x64-1.9.4.tgz#eafc2ce3849d385fc02238aad1ca4a73395a64d9"
+  integrity sha512-ngYBh/+bEedqkSevPVhLP4QfVPCpb+4BBe2p7Xs32dBgs7rh9nY2AIYUL6BgLw1JVXV8GlpKmb/hNiuIxfPfZg==
+
+"@biomejs/cli-linux-arm64-musl@1.9.4":
+  version "1.9.4"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-linux-arm64-musl/-/cli-linux-arm64-musl-1.9.4.tgz#d780c3e01758fc90f3268357e3f19163d1f84fca"
+  integrity sha512-v665Ct9WCRjGa8+kTr0CzApU0+XXtRgwmzIf1SeKSGAv+2scAlW6JR5PMFo6FzqqZ64Po79cKODKf3/AAmECqA==
+
+"@biomejs/cli-linux-arm64@1.9.4":
+  version "1.9.4"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-linux-arm64/-/cli-linux-arm64-1.9.4.tgz#8ed1dd0e89419a4b66a47f95aefb8c46ae6041c9"
+  integrity sha512-fJIW0+LYujdjUgJJuwesP4EjIBl/N/TcOX3IvIHJQNsAqvV2CHIogsmA94BPG6jZATS4Hi+xv4SkBBQSt1N4/g==
+
+"@biomejs/cli-linux-x64-musl@1.9.4":
+  version "1.9.4"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-linux-x64-musl/-/cli-linux-x64-musl-1.9.4.tgz#f36982b966bd671a36671e1de4417963d7db15fb"
+  integrity sha512-gEhi/jSBhZ2m6wjV530Yy8+fNqG8PAinM3oV7CyO+6c3CEh16Eizm21uHVsyVBEB6RIM8JHIl6AGYCv6Q6Q9Tg==
+
+"@biomejs/cli-linux-x64@1.9.4":
+  version "1.9.4"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-linux-x64/-/cli-linux-x64-1.9.4.tgz#a0a7f56680c76b8034ddc149dbf398bdd3a462e8"
+  integrity sha512-lRCJv/Vi3Vlwmbd6K+oQ0KhLHMAysN8lXoCI7XeHlxaajk06u7G+UsFSO01NAs5iYuWKmVZjmiOzJ0OJmGsMwg==
+
+"@biomejs/cli-win32-arm64@1.9.4":
+  version "1.9.4"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-win32-arm64/-/cli-win32-arm64-1.9.4.tgz#e2ef4e0084e76b7e26f0fc887c5ef1265ea56200"
+  integrity sha512-tlbhLk+WXZmgwoIKwHIHEBZUwxml7bRJgk0X2sPyNR3S93cdRq6XulAZRQJ17FYGGzWne0fgrXBKpl7l4M87Hg==
+
+"@biomejs/cli-win32-x64@1.9.4":
+  version "1.9.4"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-win32-x64/-/cli-win32-x64-1.9.4.tgz#4c7afa90e3970213599b4095e62f87e5972b2340"
+  integrity sha512-8Y5wMhVIPaWe6jw2H+KlEm4wP/f7EW3810ZLmDlrEEy5KvBsb9ECEfu/kMWD484ijfQ8+nIi0giMgu9g1UAuuA==
+
 "@changesets/apply-release-plan@^7.0.0":
   version "7.0.0"
   resolved "https://registry.yarnpkg.com/@changesets/apply-release-plan/-/apply-release-plan-7.0.0.tgz#ce3c3dfc5720550a5d592b54ad2f411f816ec5ff"

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { ConfigContext, ExpoConfig } from "@expo/config";`
	`1`	`+import type { ConfigContext, ExpoConfig } from "@expo/config";`
`2`	`2`
`3`	`3`	`export default ({ config }: ConfigContext): ExpoConfig => ({`
`4`	`4`	`...config,`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@`
`5`	`5`	`"paths": {`
`6`	`6`	`"@balloman/expo-google-maps": ["../src/index"],`
`7`	`7`	`"@balloman/expo-google-maps/": ["../src/"]`
`8`		`- }`
	`8`	`+ },`
	`9`	`+ "resolveJsonModule": true`
`9`	`10`	`}`
`10`	`11`	`}`