Issue pod install on React Native 0.84.x

[edritech93]

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch @bam.tech/react-native-image-resizer@3.0.11 for the project I'm working on.

Issue: Can't pod install

Here is the diff that solved my problem:

diff --git a/node_modules/@bam.tech/react-native-image-resizer/react-native-image-resizer.podspec b/node_modules/@bam.tech/react-native-image-resizer/react-native-image-resizer.podspec
index 1848ae8..dc0fe1e 100644
--- a/node_modules/@bam.tech/react-native-image-resizer/react-native-image-resizer.podspec
+++ b/node_modules/@bam.tech/react-native-image-resizer/react-native-image-resizer.podspec
@@ -27,7 +27,9 @@ Pod::Spec.new do |s|
         "CLANG_CXX_LANGUAGE_STANDARD" => "c++17"
     }
     s.dependency "React-Codegen"
-    s.dependency "RCT-Folly"
+    if ENV['RCT_USE_PREBUILT_RNCORE'] != '1' then
+      s.dependency "RCT-Folly"
+    end
     s.dependency "RCTRequired"
     s.dependency "RCTTypeSafety"
     s.dependency "ReactCommon/turbomodule/core"

This issue body was partially generated by patch-package.

[EliottGand]

Thanks a lot, we'll see how we can integrate that !

[manakuro]

The dependencies are already included in the install_modules_dependencies, so there's no need to add them explicitly.

https://github.com/facebook/react-native/blob/v0.84.1/packages/react-native/scripts/cocoapods/new_architecture.rb#L120-L134

diff --git a/react-native-image-resizer.podspec b/react-native-image-resizer.podspec
--- a/react-native-image-resizer.podspec
+++ b/react-native-image-resizer.podspec
@@ -26,11 +26,6 @@ Pod::Spec.new do |s|
         "OTHER_CPLUSPLUSFLAGS" => "-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1",
         "CLANG_CXX_LANGUAGE_STANDARD" => "c++17"
     }
-    s.dependency "React-Codegen"
-    s.dependency "RCT-Folly"
-    s.dependency "RCTRequired"
-    s.dependency "RCTTypeSafety"
-    s.dependency "ReactCommon/turbomodule/core"
     install_modules_dependencies(s)
   else
     s.dependency "React-Core"

[OFD16]

same issue and thanks for patch and why they dont merge it?