Skip to content

Make the medium for the vault-env volume configurable #403

Description

@carsonoid

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.
  • I agree to follow the Code of Conduct.

Problem Description

The medium for the vault-env volume is currently hard-coded to be Memory. This seems to have always been the case for the webhook.

Using Memory as the medium means that the ~26mb for the vault-env binary counts against the container memory limit. I can't see a reason for this as the default over a normal emptyDir.

This may not seem like much but if you have a node maxed out at 110 pods and each of them is using a tempfs backed volume for vault-env then that is 2,860 mb of ram being used that could have easily been on disk with no real performance or stability impact that I am aware of.

Proposed Solution

  1. A top-level configuration that tells the webhook to not set medium: Memory for a by default.
  2. A per-pod annotation that tells the webhook to not set medium: Memory for a specific pod.

Alternatives Considered

No response

Additional Information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomerskind/enhancementCategorizes issue or PR as related to an improvement.lifecycle/keepDenotes an issue or PR that should be preserved from going stale.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    Status
    🔖 Ready for work

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions