Skip to content

Commit 18ef7b3

Browse files
vigohepbalogh-sa
authored andcommitted
Fix: OwnerRefInvalidNamespace when refering to a Service Account that doesn't exists in the same namespace
1 parent c84bbdd commit 18ef7b3

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

charts/jwt-to-rbac/Chart.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
apiVersion: v2
2-
appVersion: 0.6.2
2+
appVersion: 0.6.3
33
description: A Helm chart for Kubernetes
44
name: jwt-to-rbac
5-
version: 0.6.2
5+
version: 0.6.3
66
home: https://github.com/banzaicloud/jwt-to-rbac
77
maintainers:
88
- name: BanzaiCloud

pkg/rbachandler/rbac_handler.go

+2-6
Original file line numberDiff line numberDiff line change
@@ -309,6 +309,7 @@ func (rh *RBACHandler) createRoleBinding(rb *roleBinding) error {
309309
ObjectMeta: metav1.ObjectMeta{
310310
Name: rb.name,
311311
Labels: rb.labels,
312+
OwnerReferences: []metav1.OwnerReference{},
312313
},
313314
Subjects: subjects,
314315
RoleRef: apirbacv1.RoleRef{
@@ -317,12 +318,7 @@ func (rh *RBACHandler) createRoleBinding(rb *roleBinding) error {
317318
Name: rb.roleName,
318319
},
319320
}
320-
ownerReferences, err := rh.getSAReference(rb.saName)
321-
if err != nil {
322-
return err
323-
}
324-
bindObj.SetOwnerReferences(ownerReferences)
325-
_, err = rh.rbacClientSet.RoleBindings(ns).Create(bindObj)
321+
_, err := rh.rbacClientSet.RoleBindings(ns).Create(bindObj)
326322
if err != nil {
327323
return emperror.WrapWith(err, "create rolebinding failed", "RoleBinding", rb.name)
328324
}

0 commit comments

Comments
 (0)