Skip to content

Commit 33fbb6b

Browse files
authored
Fix bug by replacing ClusterRoleBindings & RoleBindings Create function to Update. Update also create resource if doesn't exists (#96)
Signed-off-by: Victor Godoy Hernández <[email protected]>
1 parent 665c3c4 commit 33fbb6b

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

charts/jwt-to-rbac/Chart.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
apiVersion: v2
2-
appVersion: 0.6.5
2+
appVersion: 0.6.6
33
description: A Helm chart for Kubernetes
44
name: jwt-to-rbac
5-
version: 0.6.5
5+
version: 0.6.6
66
home: https://github.com/banzaicloud/jwt-to-rbac
77
maintainers:
88
- name: BanzaiCloud

pkg/rbachandler/rbac_handler.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ func (rh *RBACHandler) createClusterRoleBinding(crb *clusterRoleBinding) error {
310310
return err
311311
}
312312
bindObj.SetOwnerReferences(ownerReferences)
313-
_, err = rh.rbacClientSet.ClusterRoleBindings().Create(bindObj)
313+
_, err = rh.rbacClientSet.ClusterRoleBindings().Update(bindObj)
314314
if err != nil {
315315
return emperror.WrapWith(err, "create clusterrolebinding failed", "ClusterRoleBinding", crb.name)
316316
}
@@ -353,7 +353,7 @@ func (rh *RBACHandler) createRoleBinding(rb *roleBinding) error {
353353
Name: rb.roleName,
354354
},
355355
}
356-
_, err := rh.rbacClientSet.RoleBindings(ns).Create(bindObj)
356+
_, err := rh.rbacClientSet.RoleBindings(ns).Update(bindObj)
357357
if err != nil {
358358
return emperror.WrapWith(err, "create rolebinding failed", "RoleBinding", rb.name)
359359
}

0 commit comments

Comments
 (0)