Fix panic when pvc size is updated externally

baluchicken · baluchicken · commit 428831094d0c · 2020-06-19T11:10:31.000+02:00
diff --git a/pkg/resources/kafka/kafka.go b/pkg/resources/kafka/kafka.go
@@ -804,7 +804,8 @@ func (r *Reconciler) reconcileKafkaPvc(log logr.Logger, brokersDesiredPvcs map[s
 					}
 
 					if isDesiredStorageValueInvalid(desiredPvc, currentPvc) {
-						return errorfactory.New(errorfactory.InternalError{}, nil, "one can not reduce the size of a PVC", "kind", desiredType)
+						return errorfactory.New(errorfactory.InternalError{}, errors.New("could not modify pvc size"),
+							"one can not reduce the size of a PVC", "kind", desiredType)
 					}
 
 					resReq := desiredPvc.Spec.Resources.Requests

Original file line number	Diff line number	Diff line change
`@@ -804,7 +804,8 @@ func (r *Reconciler) reconcileKafkaPvc(log logr.Logger, brokersDesiredPvcs map[s`
`804`	`804`	`}`
`805`	`805`
`806`	`806`	`if isDesiredStorageValueInvalid(desiredPvc, currentPvc) {`
`807`		`- return errorfactory.New(errorfactory.InternalError{}, nil, "one can not reduce the size of a PVC", "kind", desiredType)`
	`807`	`+ return errorfactory.New(errorfactory.InternalError{}, errors.New("could not modify pvc size"),`
	`808`	`+ "one can not reduce the size of a PVC", "kind", desiredType)`
`808`	`809`	`}`
`809`	`810`
`810`	`811`	`resReq := desiredPvc.Spec.Resources.Requests`