Fix KafkaCluster's status update at CruiseControlTask controller (#889)

Author: bartam1

controllers/cruisecontroltask_controller.go

@@ -104,6 +104,10 @@ func (r *CruiseControlTaskReconciler) Reconcile(ctx context.Context, request ctr
 	// Update task states with information from Cruise Control
 	updateActiveTasks(tasksAndStates, ccOperations)
 
+	if err = r.UpdateStatus(ctx, instance, tasksAndStates); err != nil {
+		return requeueWithError(log, "failed to update Kafka Cluster status", err)
+	}
+
 	scaler, err := r.ScaleFactory(ctx, instance)
 	if err != nil {
 		return requeueWithError(log, "failed to create Cruise Control Scaler instance", err)
@@ -206,7 +210,7 @@ func (r *CruiseControlTaskReconciler) Reconcile(ctx context.Context, request ctr
 	}
 
 	if err = r.UpdateStatus(ctx, instance, tasksAndStates); err != nil {
-		log.Error(err, "failed to update Kafka Cluster status")
+		return requeueWithError(log, "failed to update Kafka Cluster status", err)
 	}
 
 	return reconciled()
@@ -308,7 +312,7 @@ func (r *CruiseControlTaskReconciler) UpdateStatus(ctx context.Context, instance
 
 	currentStatus := instance.Status.DeepCopy()
 	taskAndStates.SyncState(instance)
-	if reflect.DeepEqual(currentStatus, instance.Status) {
+	if reflect.DeepEqual(*currentStatus, instance.Status) {
 		log.Info("there are no updates to apply to Kafka Cluster Status")
 		return nil
 	}