Skip to content
This repository was archived by the owner on Mar 26, 2025. It is now read-only.

Commit 9f23c27

Browse files
committed
Remove TODO since the service name alone is required as well
1 parent a28f3f0 commit 9f23c27

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

pkg/util/pki/common.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ func clusterDNSNames(cluster *v1beta1.KafkaCluster) (names []string) {
122122
)
123123

124124
// service name only
125-
// TODO (tinyzimmer): I'm not sure if this one is required
126125
names = append(names,
127126
fmt.Sprintf(kafka.HeadlessServiceTemplate, cluster.Name))
128127
} else {
@@ -142,7 +141,7 @@ func clusterDNSNames(cluster *v1beta1.KafkaCluster) (names []string) {
142141
fmt.Sprintf("%s.%s", fmt.Sprintf(kafka.AllBrokerServiceTemplate, cluster.Name), cluster.Namespace),
143142
)
144143

145-
// service name only - same TODO as above
144+
// service name only
146145
names = append(names,
147146
fmt.Sprintf(kafka.AllBrokerServiceTemplate, cluster.Name))
148147
}

0 commit comments

Comments
 (0)