Skip to content
This repository was archived by the owner on Mar 26, 2025. It is now read-only.

Conversation

@jrwren
Copy link

@jrwren jrwren commented Aug 15, 2023

Description

Don't cache secrets. controller-runtime uses watches to update its cache, effectively caching every object, not just namespaced objects. See: https://stackoverflow.com/questions/75412402/golang-client-pkg-how-to-execute-a-list-secret-under-a-resourcenames-restric

On clusters with a large number of large secrets, the memory usage of the cache is too large. This isn't needed so don't do it.

Type of Change

  • Bug Fix

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@jrwren jrwren requested a review from a team as a code owner August 15, 2023 14:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant