fix: resolve email broadcast Save Draft silent failure (#567)

* fix: resolve email broadcast "Save Draft" silent failure

Remove replyTo from createEmailBroadcastWithTemplateSchema — empty string
default was failing z.email() validation silently. The backend already
pulls replyTo from the EmailAddress record when sending.

Also fix layout children type (ReactElement → ReactNode) and scope fan
unique index to workspaceId.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: align fan upsert conflict targets with updated unique index

The Fans table unique index changed from (email) to (email, workspaceId),
but two routes still used the old target, causing runtime errors on
repeat fan sign-ups.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: adambarito

apps/app/src/app/[handle]/bios/(edit)/layout.tsx

@@ -2,7 +2,7 @@ import { AppBioRender } from '~/app/[handle]/bios/_components/app-bio-render';
 import { BioKeySwitcher } from '~/app/[handle]/bios/_components/bio-key-switcher';
 import { getAllFontClassNames } from '~/lib/fonts';
 
-export default function BioEditLayout({ children }: { children: React.ReactElement }) {
+export default function BioEditLayout({ children }: { children: React.ReactNode }) {
 	// Load all fonts for bio editing pages where users can preview different fonts
 	const allFontClasses = getAllFontClassNames();
 

apps/app/src/app/[handle]/email/broadcasts/_components/create-or-update-email-broadcast-modal.tsx

@@ -167,7 +167,6 @@ export function CreateOrUpdateEmailBroadcastModal({
 			previewText: '',
 			body: '',
 			type: 'marketing',
-			replyTo: '',
 			fanGroupId: null,
 			status: 'draft',
 			scheduledAt: null,

apps/app/src/app/[handle]/layout.tsx

@@ -12,7 +12,7 @@ export default async function HandleLayout({
 	children,
 }: {
 	params: Promise<{ handle: string }>;
-	children: React.ReactElement;
+	children: React.ReactNode;
 }) {
 	const session = await getSession();
 

packages/db/src/sql/fan.sql.ts

@@ -44,7 +44,7 @@ export const Fans = pgTable(
 		stripePaymentMethodId: varchar('stripePaymentMethodId', { length: 255 }),
 	},
 	f => ({
-		unique: uniqueIndex('unique_email').on(f.email),
+		unique: uniqueIndex('unique_email').on(f.email, f.workspaceId),
 	}),
 );
 

packages/lib/src/trpc/routes/bio-render.route.ts

@@ -236,7 +236,7 @@ export const bioRenderRoute = {
 							updatedAt: new Date(),
 						})
 						.onConflictDoUpdate({
-							target: [Fans.email],
+							target: [Fans.email, Fans.workspaceId],
 							set: {
 								updatedAt: new Date(),
 								emailMarketingOptIn: marketingConsent,

packages/lib/src/trpc/routes/email-broadcast.route.ts

@@ -183,7 +183,6 @@ export const emailBroadcastRoute = {
 				previewText,
 				body,
 				type,
-				replyTo,
 				broadcastOnly,
 				// Broadcast fields
 				fanGroupId,
@@ -204,7 +203,6 @@ export const emailBroadcastRoute = {
 						previewText: previewText ?? null,
 						body,
 						type,
-						replyTo: replyTo ?? null,
 						broadcastOnly, // Hide from templates list if it's a one-off
 					})
 					.returning()

packages/lib/src/trpc/routes/vip-swap-render.route.ts

@@ -168,7 +168,7 @@ export const vipSwapRenderRoute = {
 						updatedAt: new Date(),
 					})
 					.onConflictDoUpdate({
-						target: [Fans.email], // Only email is unique, not email+workspace
+						target: [Fans.email, Fans.workspaceId], // Unique on email+workspace
 						set: {
 							updatedAt: new Date(),
 							emailMarketingOptIn: true,

packages/validators/src/schemas/email-broadcast.schema.ts

@@ -61,8 +61,6 @@ export const createEmailBroadcastWithTemplateSchema = z.object({
 	previewText: z.string().optional(),
 	body: z.string(),
 	type: z.enum(['marketing', 'transactional']).default('marketing'),
-	replyTo: z.email().optional(),
-
 	// Broadcast fields
 	fanGroupId: z.string().nullable(),
 	status: z.enum(['draft', 'scheduled']).default('draft'),