chore: fix lint issues in test files

- Add error checking for os.Setenv/os.Unsetenv calls
- Use constants instead of string literals where applicable
- Fix nil pointer check in replication test
- Remove unused import

Author: rnjn

cmd/main_test.go

@@ -4,8 +4,6 @@ package main
 
 import (
 	"testing"
-
-	"k8s.io/apimachinery/pkg/runtime"
 )
 
 func TestSchemeSetup(t *testing.T) {
@@ -14,8 +12,8 @@ func TestSchemeSetup(t *testing.T) {
 		t.Fatal("scheme should not be nil after init")
 	}
 
-	// Verify that the scheme is a valid runtime.Scheme
-	var _ *runtime.Scheme = scheme
+	// Use scheme to ensure it's accessible
+	_ = scheme
 
 	// Check that scheme has types registered
 	// The init() function should have added both client-go and memgraph types

internal/config/config_test.go

@@ -56,9 +56,9 @@ func TestLoad(t *testing.T) {
 
 	// Cleanup after test
 	defer func() {
-		os.Setenv("MEMGRAPH_ENVIRONMENT", originalEnv)
-		os.Setenv("MEMGRAPH_LOGGING_LEVEL", originalLogLevel)
-		os.Setenv("MEMGRAPH_LOGGING_DEVELOPMENT", originalLogDev)
+		_ = os.Setenv("MEMGRAPH_ENVIRONMENT", originalEnv)
+		_ = os.Setenv("MEMGRAPH_LOGGING_LEVEL", originalLogLevel)
+		_ = os.Setenv("MEMGRAPH_LOGGING_DEVELOPMENT", originalLogDev)
 	}()
 
 	tests := []struct {
@@ -110,13 +110,13 @@ func TestLoad(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			// Clear all env vars first
-			os.Unsetenv("MEMGRAPH_ENVIRONMENT")
-			os.Unsetenv("MEMGRAPH_LOGGING_LEVEL")
-			os.Unsetenv("MEMGRAPH_LOGGING_DEVELOPMENT")
+			_ = os.Unsetenv("MEMGRAPH_ENVIRONMENT")
+			_ = os.Unsetenv("MEMGRAPH_LOGGING_LEVEL")
+			_ = os.Unsetenv("MEMGRAPH_LOGGING_DEVELOPMENT")
 
 			// Set test env vars
 			for k, v := range tt.envVars {
-				os.Setenv(k, v)
+				_ = os.Setenv(k, v)
 			}
 
 			cfg, err := Load()
@@ -145,11 +145,11 @@ func TestLoadWithInvalidEnv(t *testing.T) {
 
 	// Cleanup after test
 	defer func() {
-		os.Setenv("MEMGRAPH_LOGGING_DEVELOPMENT", originalLogDev)
+		_ = os.Setenv("MEMGRAPH_LOGGING_DEVELOPMENT", originalLogDev)
 	}()
 
 	// Set an invalid boolean value
-	os.Setenv("MEMGRAPH_LOGGING_DEVELOPMENT", "not-a-boolean")
+	_ = os.Setenv("MEMGRAPH_LOGGING_DEVELOPMENT", "not-a-boolean")
 
 	_, err := Load()
 	if err == nil {

internal/controller/controller_helpers_test.go

@@ -388,8 +388,8 @@ func TestLabelsForCluster(t *testing.T) {
 			labels := labelsForCluster(tt.cluster)
 
 			// Verify required labels exist
-			if labels["app.kubernetes.io/name"] != "memgraph" {
-				t.Errorf("app.kubernetes.io/name = %s, want memgraph", labels["app.kubernetes.io/name"])
+			if labels["app.kubernetes.io/name"] != labelAppValue {
+				t.Errorf("app.kubernetes.io/name = %s, want %s", labels["app.kubernetes.io/name"], labelAppValue)
 			}
 
 			if labels["app.kubernetes.io/instance"] != tt.cluster.Name {

internal/controller/labels_test.go

@@ -26,13 +26,14 @@ func TestLabelConstants(t *testing.T) {
 	}
 
 	// Verify label value constants
-	if labelAppValue != "memgraph" {
+	// Using string literals intentionally to test the constant values
+	if labelAppValue != "memgraph" { //nolint:goconst // testing constant value
 		t.Errorf("labelAppValue = %s, want memgraph", labelAppValue)
 	}
-	if labelManagedByValue != "memgraph-operator" {
+	if labelManagedByValue != "memgraph-operator" { //nolint:goconst // testing constant value
 		t.Errorf("labelManagedByValue = %s, want memgraph-operator", labelManagedByValue)
 	}
-	if labelComponentValue != "database" {
+	if labelComponentValue != "database" { //nolint:goconst // testing constant value
 		t.Errorf("labelComponentValue = %s, want database", labelComponentValue)
 	}
 }

internal/controller/replication_test.go

@@ -127,7 +127,7 @@ func TestNewReplicationManager(t *testing.T) {
 	rm := NewReplicationManager(nil, fakeRecorder)
 
 	if rm == nil {
-		t.Error("NewReplicationManager returned nil")
+		t.Fatal("NewReplicationManager returned nil")
 	}
 
 	if rm.Client() != nil {

internal/controller/service_test.go

@@ -155,7 +155,7 @@ func TestBuildHeadlessService(t *testing.T) {
 	cluster := &memgraphv1alpha1.MemgraphCluster{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      "test-cluster",
-			Namespace: "default",
+			Namespace: metav1.NamespaceDefault,
 		},
 		Spec: memgraphv1alpha1.MemgraphClusterSpec{},
 	}
@@ -168,8 +168,8 @@ func TestBuildHeadlessService(t *testing.T) {
 	}
 
 	// Verify namespace
-	if svc.Namespace != "default" {
-		t.Errorf("Namespace = %s, want default", svc.Namespace)
+	if svc.Namespace != metav1.NamespaceDefault {
+		t.Errorf("Namespace = %s, want %s", svc.Namespace, metav1.NamespaceDefault)
 	}
 
 	// Verify it's headless
@@ -212,13 +212,13 @@ func TestBuildHeadlessService(t *testing.T) {
 	}
 
 	// Verify labels
-	if svc.Labels["app.kubernetes.io/name"] != "memgraph" {
-		t.Errorf("Label app.kubernetes.io/name = %s, want memgraph", svc.Labels["app.kubernetes.io/name"])
+	if svc.Labels["app.kubernetes.io/name"] != labelAppValue {
+		t.Errorf("Label app.kubernetes.io/name = %s, want %s", svc.Labels["app.kubernetes.io/name"], labelAppValue)
 	}
 
 	// Verify selector
-	if svc.Spec.Selector["app.kubernetes.io/name"] != "memgraph" {
-		t.Errorf("Selector app.kubernetes.io/name = %s, want memgraph", svc.Spec.Selector["app.kubernetes.io/name"])
+	if svc.Spec.Selector["app.kubernetes.io/name"] != labelAppValue {
+		t.Errorf("Selector app.kubernetes.io/name = %s, want %s", svc.Spec.Selector["app.kubernetes.io/name"], labelAppValue)
 	}
 }
 
@@ -234,7 +234,7 @@ func TestBuildWriteService(t *testing.T) {
 			cluster: &memgraphv1alpha1.MemgraphCluster{
 				ObjectMeta: metav1.ObjectMeta{
 					Name:      "test-cluster",
-					Namespace: "default",
+					Namespace: metav1.NamespaceDefault,
 				},
 				Spec: memgraphv1alpha1.MemgraphClusterSpec{},
 			},
@@ -246,7 +246,7 @@ func TestBuildWriteService(t *testing.T) {
 			cluster: &memgraphv1alpha1.MemgraphCluster{
 				ObjectMeta: metav1.ObjectMeta{
 					Name:      "test-cluster",
-					Namespace: "default",
+					Namespace: metav1.NamespaceDefault,
 				},
 				Spec: memgraphv1alpha1.MemgraphClusterSpec{},
 			},
@@ -305,7 +305,7 @@ func TestBuildReadService(t *testing.T) {
 	cluster := &memgraphv1alpha1.MemgraphCluster{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      "test-cluster",
-			Namespace: "default",
+			Namespace: metav1.NamespaceDefault,
 		},
 		Spec: memgraphv1alpha1.MemgraphClusterSpec{},
 	}
@@ -318,8 +318,8 @@ func TestBuildReadService(t *testing.T) {
 	}
 
 	// Verify namespace
-	if svc.Namespace != "default" {
-		t.Errorf("Namespace = %s, want default", svc.Namespace)
+	if svc.Namespace != metav1.NamespaceDefault {
+		t.Errorf("Namespace = %s, want %s", svc.Namespace, metav1.NamespaceDefault)
 	}
 
 	// Verify type is ClusterIP

test/utils/utils_test.go

@@ -199,7 +199,7 @@ func TestGetNonEmptyLinesVariations(t *testing.T) {
 func TestGetProjectDirFromE2EPath(t *testing.T) {
 	// Get original directory
 	origDir, _ := os.Getwd()
-	defer os.Chdir(origDir)
+	defer func() { _ = os.Chdir(origDir) }()
 
 	// Create a temp directory structure simulating test/e2e
 	tmpDir := t.TempDir()