chore: misc qol improvements #632
Annotations
12 errors and 16 warnings
|
go-test
Process completed with exit code 1.
|
|
go-test:
runner/network/consensus/sequencer_consensus.go#L244
f.options.AllowTxFailures undefined (type ConsensusClientOptions has no field or method AllowTxFailures)
|
|
go-test:
runner/network/consensus/sequencer_consensus.go#L235
f.options.AllowTxFailures undefined (type ConsensusClientOptions has no field or method AllowTxFailures)
|
|
go-lint
issues found
|
|
go-lint:
runner/network/consensus/sequencer_consensus.go#L244
f.options.AllowTxFailures undefined (type ConsensusClientOptions has no field or method AllowTxFailures)) (typecheck)
|
|
go-lint:
runner/network/consensus/sequencer_consensus.go#L235
f.options.AllowTxFailures undefined (type ConsensusClientOptions has no field or method AllowTxFailures)
|
|
go-lint:
runner/network/sequencer_benchmark.go#L12
could not import github.com/base/base-bench/runner/network/consensus (-: # github.com/base/base-bench/runner/network/consensus
|
|
go-lint:
runner/network/consensus/sequencer_consensus.go#L244
f.options.AllowTxFailures undefined (type ConsensusClientOptions has no field or method AllowTxFailures) (typecheck)
|
|
go-lint:
runner/network/consensus/sequencer_consensus.go#L235
f.options.AllowTxFailures undefined (type ConsensusClientOptions has no field or method AllowTxFailures)
|
|
basic-benchmarks
Process completed with exit code 1.
|
|
basic-benchmarks:
runner/network/consensus/sequencer_consensus.go#L244
f.options.AllowTxFailures undefined (type ConsensusClientOptions has no field or method AllowTxFailures)
|
|
basic-benchmarks:
runner/network/consensus/sequencer_consensus.go#L235
f.options.AllowTxFailures undefined (type ConsensusClientOptions has no field or method AllowTxFailures)
|
|
basic-benchmarks
the order of args in a shift operation is incorrect
|
|
basic-benchmarks
ERC20 'transfer' and 'transferFrom' calls should check the return value
|
|
basic-benchmarks
ERC20 'transfer' and 'transferFrom' calls should check the return value
|
|
basic-benchmarks
ERC20 'transfer' and 'transferFrom' calls should check the return value
|
|
basic-benchmarks
ERC20 'transfer' and 'transferFrom' calls should check the return value
|
|
basic-benchmarks
ERC20 'transfer' and 'transferFrom' calls should check the return value
|
|
basic-benchmarks
typecasts that can truncate values should be checked
|
|
basic-benchmarks
typecasts that can truncate values should be checked
|
|
basic-benchmarks
typecasts that can truncate values should be checked
|
|
basic-benchmarks
ERC20 'transfer' and 'transferFrom' calls should check the return value
|
|
basic-benchmarks:
contracts/src/Simulator.sol#L338
typecasts that can truncate values should be checked
|
|
basic-benchmarks:
contracts/src/Simulator.sol#L268
Low-level calls should check the success return value
|
|
basic-benchmarks:
contracts/src/Precompile.sol#L121
typecasts that can truncate values should be checked
|
|
basic-benchmarks:
contracts/src/Simulator.sol#L263
Low-level calls should check the success return value
|
|
basic-benchmarks:
contracts/src/Simulator.sol#L251
Low-level calls should check the success return value
|
|
basic-benchmarks:
contracts/src/Simulator.sol#L249
Low-level calls should check the success return value
|