fix(chain-1977): add zero-value checks for denominator values

Author: xenoliss

solana/programs/bridge/src/common/instructions/config/eip1559.rs

@@ -11,13 +11,13 @@ pub fn set_minimum_base_fee_handler(ctx: Context<SetBridgeConfig>, new_fee: u64)
 /// Set the window duration parameter
 pub fn set_window_duration_handler(ctx: Context<SetBridgeConfig>, new_duration: u64) -> Result<()> {
     ctx.accounts.bridge.eip1559.config.window_duration_seconds = new_duration;
+    ctx.accounts.bridge.eip1559.config.validate()?;
     Ok(())
 }
 
 /// Set the gas target parameter
 pub fn set_gas_target_handler(ctx: Context<SetBridgeConfig>, new_target: u64) -> Result<()> {
     ctx.accounts.bridge.eip1559.config.target = new_target;
-
     Ok(())
 }
 
@@ -27,5 +27,6 @@ pub fn set_adjustment_denominator_handler(
     new_denominator: u64,
 ) -> Result<()> {
     ctx.accounts.bridge.eip1559.config.denominator = new_denominator;
+    ctx.accounts.bridge.eip1559.config.validate()?;
     Ok(())
 }

solana/programs/bridge/src/common/instructions/config/gas.rs

@@ -11,6 +11,7 @@ pub fn set_gas_cost_scaler_handler(ctx: Context<SetBridgeConfig>, new_scaler: u6
 /// Set the gas cost scaler decimal precision
 pub fn set_gas_cost_scaler_dp_handler(ctx: Context<SetBridgeConfig>, new_dp: u64) -> Result<()> {
     ctx.accounts.bridge.gas_config.gas_cost_scaler_dp = new_dp;
+    ctx.accounts.bridge.gas_config.validate()?;
     Ok(())
 }
 

solana/programs/bridge/src/common/instructions/config/protocol.rs

@@ -7,21 +7,12 @@ pub fn set_block_interval_requirement_handler(
     ctx: Context<SetBridgeConfig>,
     new_interval: u64,
 ) -> Result<()> {
-    require!(
-        new_interval <= 1000,
-        SetBlockIntervalRequirementError::NewIntervalTooHigh
-    );
-
     ctx.accounts
         .bridge
         .protocol_config
         .block_interval_requirement = new_interval;
 
-    Ok(())
-}
+    ctx.accounts.bridge.protocol_config.validate()?;
 
-#[error_code]
-pub enum SetBlockIntervalRequirementError {
-    #[msg("New interval too high")]
-    NewIntervalTooHigh,
+    Ok(())
 }

solana/programs/bridge/src/common/internal/init_config.rs

@@ -22,8 +22,11 @@ pub struct Config {
 
 impl Config {
     pub fn validate(&self) -> Result<()> {
-        self.base_oracle_config.validate()?;
+        self.eip1559_config.validate()?;
+        self.gas_config.validate()?;
+        self.protocol_config.validate()?;
         self.partner_oracle_config.validate()?;
+        self.base_oracle_config.validate()?;
         Ok(())
     }
 }

solana/programs/bridge/src/common/state/bridge.rs

@@ -57,6 +57,17 @@ pub struct Eip1559Config {
     pub minimum_base_fee: u64,
 }
 
+impl Eip1559Config {
+    pub fn validate(&self) -> Result<()> {
+        require!(self.denominator > 0, BridgeError::InvalidDenominator);
+        require!(
+            self.window_duration_seconds > 0,
+            BridgeError::InvalidWindowDurationSeconds
+        );
+        Ok(())
+    }
+}
+
 impl Eip1559 {
     /// Refresh the base fee if window has expired, reset window tracking
     /// Handles multiple expired windows by processing each empty window
@@ -159,13 +170,38 @@ pub struct GasConfig {
     pub gas_per_call: u64,
 }
 
+impl GasConfig {
+    pub fn validate(&self) -> Result<()> {
+        require!(
+            self.gas_cost_scaler_dp > 0,
+            BridgeError::InvalidGasCostScalerDp
+        );
+        Ok(())
+    }
+}
+
 #[derive(Debug, Clone, PartialEq, Eq, InitSpace, AnchorSerialize, AnchorDeserialize)]
 pub struct ProtocolConfig {
     /// Block interval requirement for output root registration. Every Base block associated with a
     /// submitted output root must be a multiple of this number.
     pub block_interval_requirement: u64,
 }
 
+impl ProtocolConfig {
+    pub fn validate(&self) -> Result<()> {
+        require!(
+            self.block_interval_requirement > 0,
+            BridgeError::InvalidBlockIntervalRequirement
+        );
+
+        require!(
+            self.block_interval_requirement <= 1000,
+            BridgeError::InvalidBlockIntervalRequirement
+        );
+        Ok(())
+    }
+}
+
 #[derive(Debug, Clone, PartialEq, Eq, InitSpace, AnchorSerialize, AnchorDeserialize)]
 pub struct BufferConfig {
     /// Maximum call buffer size. This caps the max size of a Solana → Base message.
@@ -247,6 +283,14 @@ pub enum BridgeError {
     DuplicateSigner,
     #[msg("Invalid partner threshold")]
     InvalidPartnerThreshold,
+    #[msg("Invalid denominator")]
+    InvalidDenominator,
+    #[msg("Invalid window duration seconds")]
+    InvalidWindowDurationSeconds,
+    #[msg("Invalid gas cost scaler dp")]
+    InvalidGasCostScalerDp,
+    #[msg("Invalid block interval requirement")]
+    InvalidBlockIntervalRequirement,
 }
 
 #[cfg(test)]