chore(base): remove value parameter from relayMessage

Author: xenoliss

base/src/Messenger.sol

@@ -124,28 +124,20 @@ contract Messenger {
     /// @dev Gas estimation: If the transaction origin is ESTIMATION_ADDRESS, failures will cause reverts to help
     ///      compute accurate gas limits during estimation.
     ///
-    /// @param nonce       Unique nonce of the message being relayed.
-    /// @param sender      Address of the user who sent the message on the remote chain.
-    /// @param target      Address that the message is targeted at on this chain.
-    /// @param value       ETH value to send with the message execution.
+    /// @param nonce Unique nonce of the message being relayed.
+    /// @param sender Address of the user who sent the message on the remote chain.
+    /// @param target Address that the message is targeted at on this chain.
     /// @param minGasLimit Minimum amount of gas that the message must be executed with.
-    /// @param message     Encoded message data to send to the target address.
-    function relayMessage(
-        uint256 nonce,
-        bytes32 sender,
-        address target,
-        uint256 value,
-        uint256 minGasLimit,
-        bytes calldata message
-    ) external payable {
+    /// @param message Encoded message data to send to the target address.
+    function relayMessage(uint256 nonce, bytes32 sender, address target, uint256 minGasLimit, bytes calldata message)
+        external
+    {
         bytes32 messageHash =
-            keccak256(abi.encodeCall(this.relayMessage, (nonce, sender, target, value, minGasLimit, message)));
+            keccak256(abi.encodeCall(this.relayMessage, (nonce, sender, target, minGasLimit, message)));
 
         if (_isRemoteMessenger()) {
-            require(msg.value == value, IncorrectMsgValue());
             require(!failedMessages[messageHash], MessageAlreadyFailed());
         } else {
-            require(msg.value == 0, IncorrectMsgValue());
             require(failedMessages[messageHash], MessageNotAlreadyFailed());
         }
 
@@ -178,7 +170,7 @@ contract Messenger {
         }
 
         _xChainMsgSender = sender;
-        bool success = SafeCall.call(target, gasleft() - RELAY_RESERVED_GAS, value, message);
+        bool success = SafeCall.call(target, gasleft() - RELAY_RESERVED_GAS, 0, message);
         _xChainMsgSender = DEFAULT_L2_SENDER;
 
         if (success) {

solana/programs/portal/src/solidity.rs

@@ -3,21 +3,23 @@ use alloy_sol_types::sol;
 sol! {
     #[derive(Debug, PartialEq, Eq)]
     contract CrossChainMessenger {
-        /// @notice Relays a message that was sent by the remote CrossChainMessenger contract. Can only be executed via
-        ///         cross-chain call from the remote messenger OR if the message was already received once and is currently
-        ///         being replayed.
+        /// @notice Relays a message that was sent by the remote Messenger contract. Can only be executed via
+        ///         cross-chain call from the remote messenger OR if the message previously failed and is being replayed.
         ///
-        /// @param nonce Nonce of the message being relayed.
-        /// @param sender Address of the user who sent the message.
-        /// @param target Address that the message is targeted at.
-        /// @param minGasLimit Minimum amount of gas that the message can be executed with.
-        /// @param message Message to send to the target.
+        /// @dev Gas estimation: If the transaction origin is ESTIMATION_ADDRESS, failures will cause reverts to help
+        ///      compute accurate gas limits during estimation.
+        ///
+        /// @param nonce Unique nonce of the message being relayed.
+        /// @param sender Address of the user who sent the message on the remote chain.
+        /// @param target Address that the message is targeted at on this chain.
+        /// @param minGasLimit Minimum amount of gas that the message must be executed with.
+        /// @param message Encoded message data to send to the target address.
         function relayMessage(
             uint256 nonce,
             bytes32 sender,
             address target,
             uint256 minGasLimit,
             bytes calldata message
-        ) external payable;
+        ) external;
     }
 }

solana/programs/portal/src/test_utils.rs

@@ -1,4 +1,3 @@
-#[cfg(test)]
 use anchor_lang::{prelude::*, solana_program::native_token::LAMPORTS_PER_SOL};
 use litesvm::LiteSVM;
 use solana_account::Account;