Skip to content

Commit 44edf2e

Browse files
committed
Simplify the insufficient-space copy per review
Keep the user-facing message simple; the remedy lives in the self-hosting docs where the operator can act on it.
1 parent 5522898 commit 44edf2e

5 files changed

Lines changed: 5 additions & 5 deletions

File tree

app/views/account/imports/show.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
<% elsif @import.failed_due_to_invalid_export? %>
2424
<div>The .zip file you uploaded doesn’t look like a Fizzy account export.</div>
2525
<% elsif @import.failed_due_to_insufficient_space? %>
26-
<div>There wasn’t enough space to process your import. Free up at least twice the export file’s size and try again.</div>
26+
<div>There wasn’t enough storage space to process your import.</div>
2727
<% else %>
2828
<div>This may be due to corrupted export data or a conflict with existing data. Please try again with a fresh export.</div>
2929
<% end %>

app/views/mailers/import_mailer/failed.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<% elsif @import.failed_due_to_invalid_export? %>
66
<p>The ZIP file isn't a Fizzy account export.</p>
77
<% elsif @import.failed_due_to_insufficient_space? %>
8-
<p>There wasn't enough space to process your import. Free up at least twice the export file's size and try again.</p>
8+
<p>There wasn't enough storage space to process your import.</p>
99
<% else %>
1010
<p>This may be due to corrupted export data or a conflict with existing data. Please try again with a fresh export, or reach out for help if the problem persists.</p>
1111
<% end %>

app/views/mailers/import_mailer/failed.text.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ It looks like the account you are trying to import already exists.
55
<% elsif @import.failed_due_to_invalid_export? -%>
66
The ZIP file isn't a Fizzy account export.
77
<% elsif @import.failed_due_to_insufficient_space? -%>
8-
There wasn't enough space to process your import. Free up at least twice the export file's size and try again.
8+
There wasn't enough storage space to process your import.
99
<% else -%>
1010
This may be due to corrupted export data or a conflict with existing data. Please try again with a fresh export, or reach out for help if the problem persists.
1111
<% end -%>

docs/docker-deployment.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ If you do want to allow multiple accounts to be created in your instance, set `M
157157

158158
You can move an account between Fizzy instances by exporting it on the old instance and uploading the export zip to the new one during signup.
159159

160-
Imports need free space: at least twice the export file's size, beyond the export itself, since the imported attachments roughly mirror the zip's contents. If there isn't enough, the import fails fast with "There wasn't enough space to process your import." — free up space (or grow the volume) and try again. If free space can't be determined, the check is skipped and the import proceeds.
160+
Imports need free space: at least twice the export file's size, beyond the export itself, since the imported attachments roughly mirror the zip's contents. If there isn't enough, the import fails fast with "There wasn't enough storage space to process your import." — free up space (or grow the volume) and try again. If free space can't be determined, the check is skipped and the import proceeds.
161161

162162
For very large exports:
163163

test/mailers/import_mailer_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,6 @@ class ImportMailerTest < ActionMailer::TestCase
5656
email.deliver_now
5757
end
5858

59-
assert_match "twice the export file", email.body.encoded
59+
assert_match "enough storage space", email.body.encoded
6060
end
6161
end

0 commit comments

Comments
 (0)