Code review

[ghiculescu]

This is a meta-question about Fizzy, you can delete it if this is the wrong place.

Thank you for open sourcing Fizzy. And thanks in particular for not deleting all the old PRs from before the repo was open sourced. We've been learning and lot and discussing a lot through looking at old PRs.

One thing that we've noticed is that there is not much code review. Obviously PRs by non-37signals staff get review, but most PRs by 37signals staff look like they get merged by the author pretty soon after creation. Occasionally you'll see a post-merge review but often there's nothing.

Curious if this is because:

• there's lots of discussion somewhere else
• there's a thorough shaping/handoff process underpinning these PRs
• this is different to a "real" project because it's new / a simpler domain / OSS / something else
• 37s is a uniquely high trust environment
• 37s has a fundamentally different perspective on code review to other companies (or at least to mine)
• something else entirely

(You can probably guess which one I think it is!)

Thanks for reading / hopefully for answering :)

[dhh]

This all depends on the seniority of the developer, the criticality of the work, and the state of the project (released vs not). A ton of work at 37signals happens by senior developers, working on medium-or-lower criticality work, and during a prerelease state of the project. We don't need a rigid review process for that.

But for more junior programmers, their mentor (a lead+ programmer) is responsible for everything that's shipped. So then you're likely to see more reviews. We happened to only have had senior+ programmers working on Fizzy, so you see less of it.

You'll find a lot of the ideas that power this high-trust environment in The Seven Shipping Principles: https://37signals.com/seven-shipping-principles. We also did a podcast episode on it: https://37signals.com/podcast/seven-shipping-principles/

[ghiculescu]

Thank you!

[yba7580-cyber]

Hello help me the code please