mypy ignore and linting

Author: c-w-feldmann

molpipeline/pipeline/_skl_pipeline.py

@@ -10,15 +10,15 @@
 import numpy as np
 import numpy.typing as npt
 from loguru import logger
-from sklearn.base import _fit_context, clone
+from sklearn.base import _fit_context, clone  # noqa: PLC2701
 from sklearn.pipeline import Pipeline as _Pipeline
-from sklearn.pipeline import _final_estimator_has, _fit_transform_one
+from sklearn.pipeline import _final_estimator_has, _fit_transform_one  # noqa: PLC2701
 from sklearn.utils import Bunch
-from sklearn.utils._tags import Tags, get_tags
+from sklearn.utils._tags import Tags, get_tags  # noqa: PLC2701
 from sklearn.utils.metadata_routing import (
     MetadataRouter,
     MethodMapping,
-    _routing_enabled,
+    _routing_enabled,  # noqa: PLC2701
     process_routing,
 )
 from sklearn.utils.metaestimators import available_if
@@ -94,12 +94,16 @@ def _set_error_resinserter(self) -> None:
         error_filter_list = [
             n_filter for _, n_filter in self.steps if isinstance(n_filter, ErrorFilter)
         ]
-        for step in self.steps:
-            if isinstance(step[1], PostPredictionWrapper) and isinstance(
-                step[1].wrapped_estimator,
-                FilterReinserter,
-            ):
-                error_replacer_list.append(step[1].wrapped_estimator)
+        error_replacer_list.extend(
+            [
+                step[1].wrapped_estimator
+                for step in self.steps
+                if (
+                    isinstance(step[1], PostPredictionWrapper)
+                    and isinstance(step[1].wrapped_estimator, FilterReinserter)
+                )
+            ],
+        )
         for error_replacer in error_replacer_list:
             error_replacer.select_error_filter(error_filter_list)
 
@@ -231,7 +235,7 @@ def _final_estimator(
 
     # pylint: disable=too-many-locals,too-many-branches
     @override
-    def _fit(
+    def _fit(  # noqa: PLR0912
         self,
         X: Any,
         y: Any = None,
@@ -983,7 +987,7 @@ def classes_(self) -> list[Any] | npt.NDArray[Any]:
             return last_step.classes_
         raise ValueError("Last step has no classes_ attribute.")
 
-    def __sklearn_tags__(self) -> Tags:
+    def __sklearn_tags__(self) -> Tags:  # noqa: PLW3201
         """Return the sklearn tags.
 
         Returns
@@ -1093,7 +1097,7 @@ def get_metadata_routing(self) -> MetadataRouter:
                 .add(caller="score", callee="transform")
             )
 
-            router.add(method_mapping=method_mapping, **{name: trans})
+            router.add(method_mapping=method_mapping, **{name: trans})  # type: ignore
 
         # Only the _non_post_processing_steps is changed from the original
         # implementation is changed in the following line

tests/test_elements/test_mol2mol/test_mol2mol_filter.py

@@ -98,7 +98,7 @@ def test_element_filter(self) -> None:
         ]
 
         for test_params in test_params_list_with_results:
-            pipeline.set_params(**test_params["params"])
+            pipeline.set_params(**test_params["params"])  # type: ignore
             filtered_smiles = pipeline.fit_transform(SMILES_LIST)
             self.assertEqual(filtered_smiles, test_params["result"])
 
@@ -188,7 +188,7 @@ def test_complex_filter(self) -> None:
         ]
 
         for test_params in test_params_list_with_results:
-            pipeline.set_params(**test_params["params"])
+            pipeline.set_params(**test_params["params"])  # type: ignore
             filtered_smiles = pipeline.fit_transform(SMILES_LIST)
             self.assertEqual(filtered_smiles, test_params["result"])
 
@@ -276,7 +276,7 @@ def test_smarts_smiles_filter(self) -> None:
             ]
 
             for test_params in test_params_list_with_results:
-                pipeline.set_params(**test_params["params"])
+                pipeline.set_params(**test_params["params"])  # type: ignore
                 filtered_smiles = pipeline.fit_transform(SMILES_LIST)
                 self.assertEqual(filtered_smiles, test_params["result"])
 
@@ -433,7 +433,7 @@ def test_descriptor_filter(self) -> None:
         ]
 
         for test_params in test_params_list_with_results:
-            pipeline.set_params(**test_params["params"])
+            pipeline.set_params(**test_params["params"])  # type: ignore
             filtered_smiles = pipeline.fit_transform(SMILES_LIST)
             self.assertEqual(filtered_smiles, test_params["result"])