Key transformations can break

[engelsanchez]

This problem was observed as merges crashing in Riak when using the Bitcask backend. The new code may pass a {tombstone, Key} argument to a key transformation callback, which normally just take a binary key. Key transformations are used in the riak_kv_bitcask_backend to support the traditional and new key encoding format introduced in Bitcask 1.7.0/Riak 2.0.

All paths that call a key transformer must make sure that it receives only the binary key to transform.

[engelsanchez]

After some investigation: The crash happens when expiration is used and a call to bitcask merge includes some expired files. That is, files that are known to contain only expired content.

[slfritchie]

Note: According to the comments in #186 (which has now been merged to the 1.7 branch), the #186 fix should also be merged to develop. If there's room between some meetings in the KK office and wicked jet lag, I'll take a swing at it this afternoon.

[engelsanchez]

@slfritchie there are a few things to be merged to 1.7. Let's wait until 2.0.1 is released and then merge 1.7 to develop in one go. That should save some time.

[engelsanchez]

Fixed in the 1.7 branch by #186. A separate issue will track the merging of all fixes for the Riak 2.0.1 release into the develop branch