fix(json): enhance Symbol handling in serialization and deserialization

Author: StephanGerbeth

packages/operators/src/json.test.js

@@ -50,14 +50,18 @@ describe('log', () => {
         BigInt(123),
         new Date(),
         new URL('https://example.com'),
-        /\w/g
+        /\w/g,
+        Symbol.for('foo'),
+        Symbol('bar')
       ],
-      nested: Promise.resolve({
+      nested: of({
         text: Promise.resolve('hello world'),
         bigInt: BigInt(123),
         date: new Date(),
         url: new URL('https://example.com'),
         regexp: Promise.resolve(new RegExp('\\w', 'g')),
+        globalSymbol: Symbol.for('foo'),
+        symbol: Symbol('bar'),
         image: from(readFile('./packages/operators/fixtures/images/test_image.jpg'))
       })
     });

packages/operators/src/json/replacer.js

@@ -23,4 +23,4 @@ const isBigInt = value => value?.constructor === BigInt;
 const isRegExp = value => value?.constructor === RegExp;
 const isSymbol = value => value?.constructor === Symbol;
 
-const symbolToString = value => `${Symbol.keyFor(value) && 'g'}${value.toString()}`;
+const symbolToString = value => `${(Symbol.keyFor(value) && 'g') || ''}${value.toString()}`;

packages/operators/src/json/reviver.js

@@ -16,17 +16,19 @@ export const syncReviver = [
 export const createSyncReviver = (transforms = []) => [...transforms, ...syncReviver];
 export const createAsyncReviver = (transforms = []) => [...transforms, ...asyncReviver];
 
-const isValidUrl = value => URL.canParse(value) && /^[\w]+:\/\/\S+$/gm.test(value);
+const isValidUrl = value =>
+  isString(value) && URL.canParse(value) && /^[\w]+:\/\/\S+$/gm.test(value);
 
 const isValidISODateString = value => {
-  if (!/\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}.\d{3}Z/.test(value)) return false;
+  if (!isString(value) || !/\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}.\d{3}Z/.test(value)) return false;
   const d = new Date(value);
   return d instanceof Date && !isNaN(d.getTime()) && d.toISOString() === value; // valid date
 };
 
-const isBigInt = value => value?.constructor === String && /^\d+n$/.test(value);
-const isRegExp = value => value?.constructor === String && /^\/.*\/[gimuy]*$/.test(value);
-const isSymbol = value => value?.constructor === String && /(\w?)Symbol\((\w+)\)/g.test(value);
+const isString = value => value?.constructor === String;
+const isBigInt = value => isString(value) && /^\d+n$/.test(value);
+const isRegExp = value => isString(value) && /^\/.*\/[gimuy]*$/.test(value);
+const isSymbol = value => isString(value) && /(\w?)Symbol\((\w+)\)/g.test(value);
 
 const regExpFromString = value => {
   const match = value.match(/^\/(.*)\/([gimuy]*)$/);