⬆️ Phonopy: support newer versions #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of phonopy are again passing the tests, as there were some bugs with the non-analytical calculations. As the `phonopy.units` module has been deprecated from v2.38.2 we support phonopy from 2.39 onward only. See also https://phonopy.github.io/phonopy/changelog.html#arp-30-2025-version-2-38-2.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 86.46% 86.67% +0.21%
==========================================
Files 34 34
Lines 2549 2552 +3
==========================================
+ Hits 2204 2212 +8
+ Misses 345 340 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of phonopy are again passing the tests,
as there were some bugs with the non-analytical calculations.
As the
phonopy.unitsmodule has been deprecated from v2.38.2we support phonopy from 2.39 onward only.
See also https://phonopy.github.io/phonopy/changelog.html#arp-30-2025-version-2-38-2.