github: upgrade to download/artifact v4 (#130)

#129

but that PR is broke since it doesn't upgrade both halves.

commit-id:7f1b728f

Author: dhalperi

.github/workflows/reusable-integration-tests.yml

@@ -77,19 +77,19 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Download pybf whl
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: pybf_whl
       - name: Download pybf tests
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: pybf_tests
       - name: Download pybf notebooks
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: pybf_notebooks
       - name: Download questions
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: bf_questions
       - uses: actions/setup-python@v5
@@ -118,19 +118,19 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Download bf image
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: bf_image
       - name: Download pybf tests
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: pybf_tests
       - name: Download pybf notebooks
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: pybf_notebooks
       - name: Download questions
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: bf_questions
       - name: Start bf
@@ -159,23 +159,23 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Download bf image
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: bf_image
       - name: Download pybf whl
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: pybf_whl
       - name: Download pybf notebooks
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: pybf_notebooks
       - name: Download pybf tests
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: pybf_tests
       - name: Download questions
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: bf_questions
       - name: Start bf
@@ -204,23 +204,23 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Download allinone image
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: allinone_image
       - name: Download pybf whl
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: pybf_whl
       - name: Download pybf notebooks
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: pybf_notebooks
       - name: Download pybf tests
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: pybf_tests
       - name: Download questions
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: bf_questions
       - uses: actions/setup-python@v5

.github/workflows/reusable-precommit.yml

@@ -124,12 +124,12 @@ jobs:
           cp -r batfish/questions/{stable,experimental} ${QUESTION_DIR}
           tar -czf questions.tgz -C ${TMP_DIR} questions
       - name: Upload JAR
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: bf_jar
           path: allinone-bundle.jar
       - name: Upload questions
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: bf_questions
           path: questions.tgz
@@ -164,17 +164,17 @@ jobs:
           tar -czf pybatfish-tests.tgz -C pybatfish tests
           tar -czf pybatfish-notebooks.tgz -C pybatfish jupyter_notebooks
       - name: Upload pybf wheel
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: pybf_whl
           path: pybatfish/dist/*
       - name: Upload tests
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: pybf_tests
           path: pybatfish-tests.tgz
       - name: Upload notebooks
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: pybf_notebooks
           path: pybatfish-notebooks.tgz
@@ -188,11 +188,11 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
       - name: Download jar
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: bf_jar
       - name: Download questions
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: bf_questions
       - name: Setup Batfish image assets
@@ -216,16 +216,16 @@ jobs:
           outputs: type=docker,dest=/tmp/bf.tar
           context: .
       - name: Upload docker image
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: bf_image
           path: /tmp/bf.tar
       - name: Download pybf whl
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: pybf_whl
       - name: Download pybf notebooks
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: pybf_notebooks
       - name: Setup Allinone image assets
@@ -251,7 +251,7 @@ jobs:
           outputs: type=docker,dest=/tmp/allinone.tar
           context: .
       - name: Upload docker image
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: allinone_image
           path: /tmp/allinone.tar

.github/workflows/reusable-upload.yml

@@ -57,11 +57,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Download bf image
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: bf_image
       - name: Download allinone image
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: allinone_image
       - name: DockerHub Login
@@ -82,7 +82,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Download pybf whl
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: pybf_whl
           path: dist
@@ -119,11 +119,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Download bf image
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: bf_image
       - name: Download allinone image
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: allinone_image
       - name: DockerHub Login
@@ -159,7 +159,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Download pybf whl
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: pybf_whl
       - name: Prep whl