Skip to content

Commit e5e02b2

Browse files
authored
fix(agent): Agent Inbox window polish — focus ring, duplicate title, RU label (#1340)
Fixes #1339. Three small Agent Inbox chrome defects: A. Focus ring: the root container was marked .focusable() + .focused(), drawing the system focus ring around the whole window content on macOS. Keyboard navigation needs the container focusable, so keep .focusable() and add .focusEffectDisabled() (macOS 26+) to suppress the ring while preserving arrow-key/Return handling. B. Duplicate title: the in-window header Label reused the same key as the window title bar (menu.agentInbox), so 'Agent Inbox' appeared twice. Remove the duplicate header label; keep the transient navigation/recovery message banner (now shown only when a message is active, with its Divider). C. RU translation: 'Входящие агентов' reads as 'agents who entered' rather than 'agents\' inbox'. Changed to 'Входящие от агентов' via a targeted text edit (single-line xcstrings diff; no json.dump re-serialization).
1 parent a17df51 commit e5e02b2

2 files changed

Lines changed: 11 additions & 9 deletions

File tree

Pine/Agent/AgentInboxView.swift

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,22 +23,23 @@ struct AgentInboxView: View {
2323

2424
var body: some View {
2525
VStack(alignment: .leading, spacing: 0) {
26-
HStack {
27-
Label(Strings.agentInboxTitle, systemImage: MenuIcons.agentInbox)
28-
.font(.title2.weight(.semibold))
29-
Spacer()
30-
if let navigationMessage {
26+
// The window title bar already names the Agent Inbox; show a
27+
// transient banner only when a navigation/recovery message is
28+
// active (#1339 — removed the duplicate in-window header label).
29+
if let navigationMessage {
30+
HStack {
31+
Spacer()
3132
Label(navigationMessage, systemImage: "exclamationmark.triangle")
3233
.font(.caption)
3334
.foregroundStyle(.orange)
3435
.accessibilityIdentifier(
3536
AccessibilityID.agentInboxNavigationStatus
3637
)
3738
}
38-
}
39-
.padding()
39+
.padding()
4040

41-
Divider()
41+
Divider()
42+
}
4243

4344
if snapshot.isEmpty {
4445
ContentUnavailableView {
@@ -53,6 +54,7 @@ struct AgentInboxView: View {
5354
.frame(minWidth: 420, idealWidth: 720, minHeight: 360, idealHeight: 560)
5455
.focusable()
5556
.focused($hasKeyboardFocus)
57+
.focusEffectDisabled()
5658
.onAppear {
5759
synchronizeSelection()
5860
hasKeyboardFocus = true

Pine/Localizable.xcstrings

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31951,7 +31951,7 @@
3195131951
"ru": {
3195231952
"stringUnit": {
3195331953
"state": "translated",
31954-
"value": "Входящие агентов"
31954+
"value": "Входящие от агентов"
3195531955
}
3195631956
},
3195731957
"zh-Hans": {

0 commit comments

Comments
 (0)