unit test

Author: loukratz-bv

qtype/semantic/checker.py

@@ -624,8 +624,24 @@ def _validate_application(application: Application) -> None:
     Raises:
         QTypeSemanticError: If SecretReference is used but
             secret_manager is not configured, or if secret_manager
-            configuration is invalid
+            configuration is invalid, or if feedback is configured
+            without telemetry
     """
+    # Check if feedback is configured without telemetry
+    if application.telemetry is None:
+        flows_with_feedback = [
+            flow.id for flow in application.flows if flow.feedback is not None
+        ]
+        if flows_with_feedback:
+            raise QTypeSemanticError(
+                (
+                    f"Application '{application.id}' has flows with feedback "
+                    f"configured but no telemetry sink defined. "
+                    f"Flows with feedback: {', '.join(flows_with_feedback)}. "
+                    "Please add a telemetry configuration to the application."
+                )
+            )
+
     if application.secret_manager is None:
         # Check if any SecretReference is used in the application
         if _has_secret_reference(application):

tests/semantic/checker-error-specs/invalid_feedback_without_telemetry.qtype.yaml

@@ -0,0 +1,27 @@
+id: test_feedback_without_telemetry
+description: Test that feedback requires telemetry to be configured
+
+flows:
+  - id: chat
+    description: Flow with feedback but no telemetry (should fail validation)
+    interface:
+      type: Conversational
+    feedback:
+      type: thumbs
+      explanation: false
+    variables:
+      - id: msg
+        type: ChatMessage
+    steps:
+      - type: Echo
+        id: echo
+        inputs:
+          - msg
+        outputs:
+          - msg
+    inputs:
+      - msg
+    outputs:
+      - msg
+
+# Note: No telemetry configured - this should cause validation error

tests/semantic/test_checker_validation.py

@@ -105,6 +105,10 @@
             "invalid_secret_manager_wrong_auth_type.qtype.yaml",
             "AWSSecretManager 'my_secret_manager' requires an AWSAuthProvider",
         ),
+        (
+            "invalid_feedback_without_telemetry.qtype.yaml",
+            "has flows with feedback configured but no telemetry sink defined",
+        ),
         (
             "invalid_complete_flow_no_text_output.qtype.yaml",
             "final step 'echo_step' is of type 'Echo' which does not support streaming",