fix autotest linting errors, rename variables

Author: bazarovstas

brain_games/constants.py

@@ -1,8 +1,8 @@
-EVEN_GAME_BRIEFING = 'Answer "yes" if the number is even, otherwise answer "no".'
-CALC_GAME_BRIEFING = 'What is the result of the expression?'
-GCD_GAME_BRIEFING = 'Find the greatest common divisor of given numbers.'
-PROG_GAME_BRIEFING = 'What number is missing in the progression?'
-PRIME_GAME_BRIEFING = 'Answer "yes" if given number is prime. Otherwise answer "no".'
+EVEN_BRIEFING = 'Answer "yes" if the number is even, otherwise answer "no".'
+CALC_BRIEFING = 'What is the result of the expression?'
+GCD_BRIEFING = 'Find the greatest common divisor of given numbers.'
+PROG_BRIEFING = 'What number is missing in the progression?'
+PRIME_BRIEFING = 'Answer "yes" if given number is prime. Otherwise answer "no".'
 
 NUMBER_OF_GAMES = 3
 PROGRESSION_LENGTH = 9

brain_games/game_engine.py

@@ -3,7 +3,9 @@
 
 
 def game_engine(get_question_and_answer, briefing):
-    username = prompt.string('Welcome to the Brain Games!\n''May I have your name? ')
+    username = prompt.string(
+        'Welcome to the Brain Games!\n''May I have your name? '
+    )
     print(f'Hello, {username}!')
     print(briefing)
     for _ in range(const.NUMBER_OF_GAMES):

brain_games/games/calc.py

@@ -1,10 +1,10 @@
 from random import choice
-from brain_games.utils import get_random_number
+from brain_games.utils import get_random_num
 from brain_games.game_engine import game_engine
 from brain_games.constants import CALC_GAME_BRIEFING
 
 
-def get_random_math_sym_and_calc_answer(num1: int, num2: int) -> list[str | int]:
+def get_random_math_sym_and_answer(num1: int, num2: int) -> list[str | int]:
     return choice([
         ['+', num1 + num2],
         ['-', num1 - num2],
@@ -13,8 +13,8 @@ def get_random_math_sym_and_calc_answer(num1: int, num2: int) -> list[str | int]
 
 
 def get_expression_and_answer():
-    num1, num2 = get_random_number(max_range=15), get_random_number(max_range=10)
-    random_math_symbol, answer = get_random_math_sym_and_calc_answer(num1, num2)
+    num1, num2 = get_random_num(max_range=15), get_random_num(max_range=10)
+    random_math_symbol, answer = get_random_math_sym_and_answer(num1, num2)
     question = f'{num1} {random_math_symbol} {num2}'
     return question, str(answer)
 

brain_games/games/even.py

@@ -1,17 +1,17 @@
-from brain_games.utils import get_random_number
+from brain_games.utils import get_random_num
 from brain_games.game_engine import game_engine
-from brain_games.constants import EVEN_GAME_BRIEFING
+from brain_games.constants import EVEN_BRIEFING
 
 
 def is_even(number: int) -> bool:
     return number % 2 == 0
 
 
 def get_random_num_and_answer():
-    random_number = get_random_number()
+    random_number = get_random_num()
     even_check = 'yes' if is_even(random_number) else 'no'
     return random_number, even_check
 
 
 def even_game():
-    game_engine(get_random_num_and_answer, EVEN_GAME_BRIEFING)
+    game_engine(get_random_num_and_answer, EVEN_BRIEFING)

brain_games/games/gcd.py

@@ -1,7 +1,7 @@
 from math import gcd
 from brain_games.utils import get_random_number
 from brain_games.game_engine import game_engine
-from brain_games.constants import GCD_GAME_BRIEFING
+from brain_games.constants import GCD_BRIEFING
 
 
 def get_random_numbers_and_answer():
@@ -12,4 +12,4 @@ def get_random_numbers_and_answer():
 
 
 def gcd_game():
-    game_engine(get_random_numbers_and_answer, GCD_GAME_BRIEFING)
+    game_engine(get_random_numbers_and_answer, GCD_BRIEFING)

brain_games/games/prime.py

@@ -1,6 +1,6 @@
 from brain_games.utils import get_random_number
 from brain_games.game_engine import game_engine
-from brain_games.constants import PRIME_GAME_BRIEFING
+from brain_games.constants import PRIME_BRIEFING
 
 
 def is_prime(number):
@@ -22,4 +22,4 @@ def get_random_number_and_answer():
 
 
 def prime_game():
-    game_engine(get_random_number_and_answer, PRIME_GAME_BRIEFING)
+    game_engine(get_random_number_and_answer, PRIME_BRIEFING)

brain_games/games/progression.py

@@ -2,23 +2,23 @@
 from brain_games.utils import get_random_number
 from brain_games.game_engine import game_engine
 from brain_games.constants import PROGRESSION_LENGTH
-from brain_games.constants import PROG_GAME_BRIEFING
+from brain_games.constants import PROG_BRIEFING
 
 
 def get_random_sequence_and_answer():
     random_step = get_random_number(min_range=2, max_range=5)
     start_number = get_random_number(max_range=15)
-    sequence = []
-    sequence.append(start_number)
+    seq = []
+    seq.append(start_number)
     for i in range(PROGRESSION_LENGTH):
-        sequence += [sequence[i] + random_step]
-    missed_num_index = choice(sequence)
+        seq += [seq[i] + random_step]
+    missed_index = choice(seq)
     question = ''
-    for i in range(len(sequence)):
-        print(sequence[i])
-        question += ' ' + str(sequence[i]) if sequence[i] != missed_num_index else ' ..'
-    return question.strip(), str(missed_num_index)
+    for i in range(len(seq)):
+        print(seq[i])
+        question += ' ' + str(seq[i]) if seq[i] != missed_index else ' ..'
+    return question.strip(), str(missed_index)
 
 
 def progression_game():
-    game_engine(get_random_sequence_and_answer, PROG_GAME_BRIEFING)
+    game_engine(get_random_sequence_and_answer, PROG_BRIEFING)

brain_games/utils.py

@@ -1,6 +1,6 @@
 import random
 
 
-def get_random_number(min_range: int = 1, max_range: int = 100) -> int:
+def get_random_num(min_range: int = 1, max_range: int = 100) -> int:
     random_number = random.randint(min_range, max_range)
     return random_number