Skip to content

Commit f4f3195

Browse files
committed
refactoring according to mentor's edits (prime game), improved readability even.py
1 parent 7927866 commit f4f3195

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

brain_games/games/even.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ def is_even(number: int) -> bool:
99

1010
def get_random_num_and_answer():
1111
random_number = get_random_number()
12-
even_check = is_even(random_number)
13-
return random_number, 'yes' if even_check else 'no'
12+
even_check = 'yes' if is_even(random_number) else 'no'
13+
return random_number, even_check
1414

1515

1616
def even_game():

brain_games/games/prime.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,20 @@
55

66
def is_prime(number):
77
if number == 1:
8-
return 'no'
9-
divisor = 2
10-
while number % divisor != 0:
11-
divisor += 1
12-
return 'yes' if number == divisor else 'no'
8+
return False
9+
if number % 2 == 0:
10+
return number == 2
11+
square_root = int(number ** 0.5) + 1
12+
for divisor in range(3, square_root, 2):
13+
if number % divisor == 0:
14+
return False
15+
return True
1316

1417

1518
def get_random_number_and_answer():
1619
random_number = get_random_number()
17-
return str(random_number), is_prime(random_number)
20+
prime_check = 'yes' if is_prime(random_number) else 'no'
21+
return str(random_number), prime_check
1822

1923

2024
def prime_game():

0 commit comments

Comments
 (0)