Skip to content

write_source_files: wrong runfiles_dir assignment with runfiles enabled for windows #1223

@tkctec

Description

@tkctec

With "--enable_runfiles" on windows, the explicit setting of "runfiles_dir" will lead to errors in sub-targets of write_source_files.

Reproduce:

  • bazel clean
  • bazel run //lib/tests/write_source_files:macro_smoke_test --enable_runfiles

Error:
ERROR: Manifest file C:\Users\xxx\_bazel_XXX\ne3nnzly\execroot\_main\bazel-out\x64_windows-fastbuild\bin\lib\tests\write_source_files\macro_smoke_test_0_update.bat.runfiles_manifest does not exist.

Suggested fix:

  • rename "runfiles_dir" -> "current_working_dir" in lib/private/write_source_file.bzl

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions