Stop including deprecated properties in context by default

Author: dzbarsky

extras/gomock.bzl

@@ -32,7 +32,7 @@ _MOCKGEN_TOOL = Label("//extras/gomock:mockgen")
 _MOCKGEN_MODEL_LIB = Label("//extras/gomock:mockgen_model")
 
 def _gomock_source_impl(ctx):
-    go = go_context(ctx, include_deprecated_properties = False)
+    go = go_context(ctx)
 
     # In Source mode, it's not necessary to pass through a library, as the only thing we use it for is setting up
     # the relative file locations. Forcing users to pass a library makes it difficult in the case where a mock should
@@ -313,7 +313,7 @@ _gomock_prog_gen = rule(
 )
 
 def _gomock_prog_exec_impl(ctx):
-    go = go_context(ctx, include_deprecated_properties = False)
+    go = go_context(ctx)
 
     args = ["-exec_only", ctx.file.prog_bin.path]
     args, needed_files = _handle_shared_args(ctx, args)

go/private/context.bzl

@@ -457,7 +457,7 @@ default_go_config_info = GoConfigInfo(
 def go_context(
         ctx,
         attr = None,
-        include_deprecated_properties = True,
+        include_deprecated_properties = False,
         importpath = None,
         importmap = None,
         embed = None,

go/private/rules/binary.bzl

@@ -117,7 +117,6 @@ def _go_binary_impl(ctx):
     """go_binary_impl emits actions for compiling and linking a go executable."""
     go = go_context(
         ctx,
-        include_deprecated_properties = False,
         importpath = ctx.attr.importpath,
         embed = ctx.attr.embed,
         # It's a list because it is transitioned.

go/private/rules/library.bzl

@@ -38,7 +38,6 @@ def _go_library_impl(ctx):
     """Implements the go_library() rule."""
     go = go_context(
         ctx,
-        include_deprecated_properties = False,
         importpath = ctx.attr.importpath,
         importmap = ctx.attr.importmap,
         importpath_aliases = ctx.attr.importpath_aliases,
@@ -209,7 +208,7 @@ go_library = rule(
 
 def _go_tool_library_impl(ctx):
     """Implements the go_tool_library() rule."""
-    go = go_context(ctx, include_deprecated_properties = False)
+    go = go_context(ctx)
 
     go_info = new_go_info(go, ctx.attr)
     archive = go.archive(go, go_info)

go/private/rules/nogo.bzl

@@ -38,7 +38,7 @@ def _nogo_impl(ctx):
         return None
 
     # Generate the source for the nogo binary.
-    go = go_context(ctx, include_deprecated_properties = False)
+    go = go_context(ctx)
     nogo_main = go.declare_file(go, path = "nogo_main.go")
     nogo_args = ctx.actions.args()
     nogo_args.add("gennogomain")

go/private/rules/source.bzl

@@ -28,7 +28,7 @@ load(
 
 def _go_source_impl(ctx):
     """Implements the go_source() rule."""
-    go = go_context(ctx, include_deprecated_properties = False)
+    go = go_context(ctx)
     go_info = new_go_info(go, ctx.attr)
     return [
         go_info,

go/private/rules/stdlib.bzl

@@ -30,7 +30,7 @@ load(
 )
 
 def _stdlib_impl(ctx):
-    go = go_context(ctx, include_deprecated_properties = False)
+    go = go_context(ctx)
     return go.toolchain.actions.stdlib(go)
 
 stdlib = rule(

go/private/rules/test.bzl

@@ -59,7 +59,6 @@ def _go_test_impl(ctx):
 
     go = go_context(
         ctx,
-        include_deprecated_properties = False,
         importpath = ctx.attr.importpath,
         embed = ctx.attr.embed,
         # It's a list because it is transitioned.

proto/compiler.bzl

@@ -94,8 +94,8 @@ compiler. Typically, these are Well Known Types and proto runtime libraries.""",
         "valid_archive": """A Boolean indicating whether the .go files produced
 by this compiler are buildable on their own. Compilers that just add methods
 to structs produced by other compilers will set this to False.""",
-        "always_generates": """A Boolean indicating whether this compiler 
-        always generates files, regardless of whether the proto files have 
+        "always_generates": """A Boolean indicating whether this compiler
+        always generates files, regardless of whether the proto files have
         relevant definitions (e.g., services for grpc_gateway). This allows
         more strict check of compiler output.""",
         "internal": "Opaque value containing data used by compile.",
@@ -217,7 +217,7 @@ def proto_path(src, proto):
     return src.path[len(prefix):]
 
 def _go_proto_compiler_impl(ctx):
-    go = go_context(ctx, include_deprecated_properties = False)
+    go = go_context(ctx)
     go_info = new_go_info(go, ctx.attr)
     proto_toolchain = _find_toolchain(
         ctx,

proto/def.bzl

@@ -83,7 +83,6 @@ declares the \"{attr_name}\" attribute.""".format(
     go = go_context(
         ctx,
         attr,
-        include_deprecated_properties = False,
         importpath = attr.importpath,
         go_context_data = attr._go_context_data,
     )
@@ -111,7 +110,6 @@ def _proto_library_to_source(_go, attr, source, merge):
 def _go_proto_library_impl(ctx):
     go = go_context(
         ctx,
-        include_deprecated_properties = False,
         importpath = ctx.attr.importpath,
         importmap = ctx.attr.importmap,
         importpath_aliases = ctx.attr.importpath_aliases,