sdk: symlink everything under lib/ when using local SDK (#3074)

irfansharif · web-flow · commit 8553d9767474 · 2022-03-14T21:20:01.000-07:00
We rely on the packaged zoneinfo zip in CRDB, found under lib/time/zoneinfo.zip. When using the remote SDK macro, we untar the entire archive into the sandbox. When pointing to a local SDK however, we previously ignored everything under lib. It feels reasonable to also symlink lib/ into the sandbox given they have valid symbols to build against. We needed this patch in order to build CRDB with local go installations. +cc cockroachdb/cockroach#56178
diff --git a/go/private/sdk.bzl b/go/private/sdk.bzl
@@ -219,7 +219,7 @@ def _remote_sdk(ctx, urls, strip_prefix, sha256):
         )
 
 def _local_sdk(ctx, path):
-    for entry in ["src", "pkg", "bin"]:
+    for entry in ["src", "pkg", "bin", "lib"]:
         ctx.symlink(path + "/" + entry, entry)
 
 def _sdk_build_file(ctx, platform):

Original file line number	Diff line number	Diff line change
`@@ -219,7 +219,7 @@ def _remote_sdk(ctx, urls, strip_prefix, sha256):`
`219`	`219`	`)`
`220`	`220`
`221`	`221`	`def _local_sdk(ctx, path):`
`222`		`- for entry in ["src", "pkg", "bin"]:`
	`222`	`+ for entry in ["src", "pkg", "bin", "lib"]:`
`223`	`223`	`ctx.symlink(path + "/" + entry, entry)`
`224`	`224`
`225`	`225`	`def _sdk_build_file(ctx, platform):`