Skip to content

Remove diagnostic warning if force_version is set #1333

Open
@fzakaria

Description

@fzakaria

Our developers get concerned when they see messages like:

Please remove duplicate artifacts from the artifact list so you do not get unexpected artifact versions

This message can be present even though we use set_version such as in

use_repo(maven, "maven", "rules_proto_grpc_java_maven")
maven.artifact(
    name = "rules_proto_grpc_java_maven",
    artifact = "protobuf-java",
    force_version = True,
    group = "com.google.protobuf",
    version = "3.25.5",
)
maven.artifact(
    name = "rules_proto_grpc_java_maven",
    artifact = "protobuf-java-util",
    force_version = True,
    group = "com.google.protobuf",
    version = "3.25.5",
)

I think a good improvement to the UX would be to not display this message if there are duplicate versions only if only one of them has force_version set.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions