Skip to content

Commit 153cd20

Browse files
authored
fix: register Node.js toolchains in correct order (#3750)
1 parent 4c37320 commit 153cd20

File tree

1 file changed

+19
-1
lines changed

1 file changed

+19
-1
lines changed

MODULE.bazel

+19-1
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,22 @@ node = use_extension("@rules_nodejs//nodejs:extensions.bzl", "node")
1717
node.toolchain(name = "nodejs")
1818
use_repo(node, "nodejs_toolchains")
1919

20-
register_toolchains("@nodejs_toolchains//:all")
20+
# Toolchain registration under bzlmod should match the order of WORKSPACE registration
21+
# which is the order specified in the PLATFORMS dict https://github.com/bazelbuild/rules_nodejs/blob/4c373209b058d46f2a5f9ab9f8abf11b161ae459/nodejs/private/nodejs_toolchains_repo.bzl#L20.
22+
# For each platform, `:<PLATFORM>_toolchain_target` should be registered before `:<PLATFORM>_toolchain`,
23+
# https://github.com/bazelbuild/rules_nodejs/blob/4c373209b058d46f2a5f9ab9f8abf11b161ae459/nodejs/repositories.bzl#L461/.
24+
# See https://github.com/bazelbuild/bazel/issues/19645 and https://github.com/bazelbuild/rules_nodejs/pull/3750 for more context.
25+
register_toolchains("@nodejs_toolchains//:linux_amd64_toolchain_target")
26+
register_toolchains("@nodejs_toolchains//:linux_amd64_toolchain")
27+
register_toolchains("@nodejs_toolchains//:linux_arm64_toolchain_target")
28+
register_toolchains("@nodejs_toolchains//:linux_arm64_toolchain")
29+
register_toolchains("@nodejs_toolchains//:linux_s390x_toolchain_target")
30+
register_toolchains("@nodejs_toolchains//:linux_s390x_toolchain")
31+
register_toolchains("@nodejs_toolchains//:linux_ppc64le_toolchain_target")
32+
register_toolchains("@nodejs_toolchains//:linux_ppc64le_toolchain")
33+
register_toolchains("@nodejs_toolchains//:darwin_amd64_toolchain_target")
34+
register_toolchains("@nodejs_toolchains//:darwin_amd64_toolchain")
35+
register_toolchains("@nodejs_toolchains//:darwin_arm64_toolchain_target")
36+
register_toolchains("@nodejs_toolchains//:darwin_arm64_toolchain")
37+
register_toolchains("@nodejs_toolchains//:windows_amd64_toolchain_target")
38+
register_toolchains("@nodejs_toolchains//:windows_amd64_toolchain")

0 commit comments

Comments
 (0)