invalid user-provided repo name

[keith]

🐞 bug report

Affected Rule

pip.parse

Is this a regression?

Yes, in 1.4.0-rc0, bisected to 965dd51

Description

with this requirements.txt

gptqmodel @ https://github.com/ModelCloud/GPTQModel/releases/download/v2.0.0/gptqmodel-2.0.0+cu126torch2.6-cp312-cp312-linux_x86_64.whl

pip.parse fails with:

ERROR: /home/ubuntu/.cache/bazel/_bazel_ubuntu/46f0c9813505c30d178a2aff399354ea/external/rules_python+/python/private/pypi/extension.bzl:613:20: Traceback (most recent call last):
        File "/home/ubuntu/.cache/bazel/_bazel_ubuntu/46f0c9813505c30d178a2aff399354ea/external/rules_python+/python/private/pypi/extension.bzl", line 613, column 20, in _pip_impl
                whl_library(name = name, **args)
Error in repository_rule: invalid user-provided repo name 'pip_311_gptqmodel_2_0_0+cu126torch2_6_cp312_cp312_linux_x86_64': valid names may contain only A-Z, a-z, 0-9, '-', '_', '.', and must start with a letter

🔬 Minimal Reproduction

bazel build ... in #2800

🌍 Your Environment

Operating System:

  
linux x86_64
  

Output of bazel version:

  
8.2.1
  

Rules_python version:

  
1.4.0-rc0
  

[keith]

cc @Yanpei-Wang

[keith]

another case with url escaping:

Error in repository_rule: invalid user-provided repo name 'modular_nvidia_gpu_pip_deps_312_torch_2_6_0%2Bcu126_cp312_cp312_manylinux_2_28_x86_64': valid names may contain only A-Z, a-z, 0-9, '-', '_', '.', and must start with a letter

[keith]

potential fix: #2801

[aignas]

I think the problem is that we are picking the name from the wrong location, but escaping may work as well.