Skip to content

Commit 8f69486

Browse files
authored
Update dependencyanalyzer3 for Scala 3.5 (#1628)
Part of #1482. Avoids a future Scala 3.5 compatibility issue under Bzlmod. PR #1604 added Scala 3.5 suppport. I updated my Bzlmod working branch to include those changes, and updated `scala_3_5.bzl` with dependencies I'd added or updated from `scala_3_4.bzl`. `./test_examples.sh` then failed with the following error, which I recreated in the local `examples/scala3` repo: ```txt $ bazel build --repo_env=SCALA_VERSION=3.5.0 //... ERROR: .../external/rules_scala~/third_party/dependency_analyzer/src/main/BUILD:4:39: scala @@rules_scala~//third_party/dependency_analyzer/src/main:dependency_analyzer failed: (Exit 1): scalac_bootstrap failed: error executing Scalac command (from target @@rules_scala~//third_party/dependency_analyzer/src/main:dependency_analyzer) bazel-out/.../bin/external/rules_scala~/src/java/io/bazel/rulesscala/scalac/scalac_bootstrap ... (remaining 1 argument skipped) -- [E164] Declaration Error: external/rules_scala~/third_party/dependency_analyzer/src/main/io/bazel/rulesscala/dependencyanalyzer3/DependencyAnalyzer.scala:21:6 21 | def init(options: List[String]): List[PluginPhase] = | ^ |error overriding method init in trait StandardPlugin of type (options: List[String]): List[dotty.tools.dotc.plugins.PluginPhase]; | method init of type (options: List[String]): List[dotty.tools.dotc.plugins.PluginPhase] needs `override` modifier ``` This may be because I bumped `io_bazel_rules_scala_scala_library_2` from `org.scala-lang:scala-library:2.13.12` to 2.13.14 in my Bzlmod branch. That's my guess based on information about the `dotty` packages from the following files: - `third_party/utils/src/test/io/bazel/rulesscala/utils/Scala3CompilerUtils.scala` - `third_party/dependency_analyzer/src/test/analyzer_test_scala_3.bzl` It's interesting that Scala 3.{1,2,3,4} all passed with that `scala-library` version bump, but without this change, but I can't explain why.
1 parent fa7c661 commit 8f69486

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

third_party/dependency_analyzer/src/main/io/bazel/rulesscala/dependencyanalyzer3/DependencyAnalyzer.scala

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class DependencyAnalyzer extends StandardPlugin:
1818
"dependencies which are directly included in the code, or " +
1919
"including unused dependencies."
2020

21-
def init(options: List[String]): List[PluginPhase] =
21+
override def init(options: List[String]): List[PluginPhase] =
2222
(new DependencyAnalyzerPhase) :: Nil
2323

2424
class DependencyAnalyzerPhase extends PluginPhase:
@@ -30,4 +30,4 @@ class DependencyAnalyzerPhase extends PluginPhase:
3030
override val runsBefore = Set(Staging.name)
3131

3232
override def transformApply(tree: Apply)(implicit ctx: Context): Tree =
33-
tree
33+
tree

0 commit comments

Comments
 (0)