Remove use of struct.to_json() (#936)

nataliejameson · web-flow · commit 8da30c9802a3 · 2025-01-13T20:39:30.000Z
Bazel 8 does not appear to support struct.to_json() anymore, so remove its usage in vfs_overlay. It appears this API has been around since at least 6.5 (https://bazel.build/versions/6.5.0/rules/lib/core/json), so changing to it shouldn't be an issue.
diff --git a/rules/framework/vfs_overlay.bzl b/rules/framework/vfs_overlay.bzl
@@ -426,7 +426,7 @@ def make_vfsoverlay(ctx, hdrs, module_map, private_hdrs, has_swift, swiftmodules
             "contents": roots,
         }],
     }
-    vfsoverlay_yaml = struct(**vfsoverlay_object).to_json()
+    vfsoverlay_yaml = json.encode(vfsoverlay_object)
     ctx.actions.write(
         content = vfsoverlay_yaml,
         output = output,

Original file line number	Diff line number	Diff line change
`@@ -426,7 +426,7 @@ def make_vfsoverlay(ctx, hdrs, module_map, private_hdrs, has_swift, swiftmodules`
`426`	`426`	`"contents": roots,`
`427`	`427`	`}],`
`428`	`428`	`}`
`429`		`- vfsoverlay_yaml = struct(**vfsoverlay_object).to_json()`
	`429`	`+ vfsoverlay_yaml = json.encode(vfsoverlay_object)`
`430`	`430`	`ctx.actions.write(`
`431`	`431`	`content = vfsoverlay_yaml,`
`432`	`432`	`output = output,`