Skip to content

Commit 9bceb55

Browse files
authored
Handle swift.swift_disable_import_underlying_module in features (#892)
When the `swift.swift_disable_import_underlying_module` is provided via the `features` attr this would previously do nothing, now it properly stops using `-import-underlying`
1 parent 4c016ec commit 9bceb55

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

rules/library.bzl

+2-1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ load("@build_bazel_rules_apple//apple/internal/resource_rules:apple_intent_libra
1010
load("@build_bazel_rules_swift//swift:swift.bzl", "swift_library")
1111
load("//rules:precompiled_apple_resource_bundle.bzl", "precompiled_apple_resource_bundle")
1212
load("//rules:hmap.bzl", "headermap")
13+
load("//rules:features.bzl", "feature_names")
1314
load("//rules/framework:vfs_overlay.bzl", "framework_vfs_overlay", VFS_OVERLAY_FRAMEWORK_SEARCH_PATH = "FRAMEWORK_SEARCH_PATH")
1415
load("//rules/library:resources.bzl", "wrap_resources_in_filegroup")
1516
load("//rules/library:xcconfig.bzl", "copts_by_build_setting_with_defaults")
@@ -937,7 +938,7 @@ def apple_library(
937938

938939
additional_swift_copts += select({
939940
"@build_bazel_rules_ios//:swift_disable_import_underlying_module": [],
940-
"//conditions:default": ["-import-underlying-module"],
941+
"//conditions:default": ["-import-underlying-module"] if not feature_names.swift_disable_import_underlying_module in features else [],
941942
})
942943

943944
swiftc_inputs = other_inputs + objc_hdrs + objc_private_hdrs

0 commit comments

Comments
 (0)