Skip to content

Commit 9a24de0

Browse files
committed
move curl to bzlmod
1 parent c988bbe commit 9a24de0

File tree

3 files changed

+8
-30
lines changed

3 files changed

+8
-30
lines changed

modules/opentelemetry-cpp/1.14.2/MODULE.bazel

+2-5
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ single_version_override(
1212
)
1313

1414
bazel_dep(name = "bazel_skylib", version = "1.5.0")
15+
bazel_dep(name = "curl", version = "8.4.0")
1516
bazel_dep(name = "grpc", version = "1.56.3.bcr.1", repo_name = "com_github_grpc_grpc")
1617
bazel_dep(name = "nlohmann_json", version = "3.11.3", repo_name = "github_nlohmann_json")
1718
bazel_dep(name = "opentracing-cpp", version = "1.6.0", repo_name = "com_github_opentracing")
@@ -26,8 +27,4 @@ bazel_dep(name = "google_benchmark", version = "1.8.3", dev_dependency = True, r
2627
bazel_dep(name = "googletest", version = "1.14.0.bcr.1", dev_dependency = True, repo_name = "com_google_googletest")
2728

2829
non_module_deps = use_extension("//bazel:non_module_deps.bzl", "non_module_deps")
29-
use_repo(
30-
non_module_deps,
31-
"com_github_opentelemetry_proto",
32-
"curl",
33-
)
30+
use_repo(non_module_deps, "com_github_opentelemetry_proto")
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
1-
diff --git a/MODULE.bazel b/MODULE.bazel
2-
new file mode 100644
3-
index 00000000..749eaab9
41
--- /dev/null
52
+++ b/MODULE.bazel
6-
@@ -0,0 +1,33 @@
3+
@@ -0,0 +1,30 @@
74
+module(
85
+ name = "opentelemetry-cpp",
96
+ version = "1.14.2",
@@ -18,6 +15,7 @@ index 00000000..749eaab9
1815
+)
1916
+
2017
+bazel_dep(name = "bazel_skylib", version = "1.5.0")
18+
+bazel_dep(name = "curl", version = "8.4.0")
2119
+bazel_dep(name = "grpc", version = "1.56.3.bcr.1", repo_name = "com_github_grpc_grpc")
2220
+bazel_dep(name = "nlohmann_json", version = "3.11.3", repo_name = "github_nlohmann_json")
2321
+bazel_dep(name = "opentracing-cpp", version = "1.6.0", repo_name = "com_github_opentracing")
@@ -32,17 +30,11 @@ index 00000000..749eaab9
3230
+bazel_dep(name = "googletest", version = "1.14.0.bcr.1", dev_dependency = True, repo_name = "com_google_googletest")
3331
+
3432
+non_module_deps = use_extension("//bazel:non_module_deps.bzl", "non_module_deps")
35-
+use_repo(
36-
+ non_module_deps,
37-
+ "com_github_opentelemetry_proto",
38-
+ "curl",
39-
+)
40-
diff --git a/bazel/non_module_deps.bzl b/bazel/non_module_deps.bzl
41-
new file mode 100644
42-
index 00000000..e70d82d3
33+
+use_repo(non_module_deps, "com_github_opentelemetry_proto")
34+
4335
--- /dev/null
4436
+++ b/bazel/non_module_deps.bzl
45-
@@ -0,0 +1,27 @@
37+
@@ -0,0 +1,16 @@
4638
+"""Load dependencies that aren't supported in bzlmod yet."""
4739
+
4840
+load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
@@ -58,15 +50,4 @@ index 00000000..e70d82d3
5850
+ ],
5951
+ )
6052
+
61-
+ http_archive(
62-
+ name = "curl",
63-
+ build_file = "@io_opentelemetry_cpp//bazel:curl.BUILD",
64-
+ sha256 = "816e41809c043ff285e8c0f06a75a1fa250211bbfb2dc0a037eeef39f1a9e427",
65-
+ strip_prefix = "curl-8.4.0",
66-
+ urls = [
67-
+ "https://curl.haxx.se/download/curl-8.4.0.tar.gz",
68-
+ "https://github.com/curl/curl/releases/download/curl-8_4_0/curl-8.4.0.tar.gz",
69-
+ ],
70-
+ )
71-
+
7253
+non_module_deps = module_extension(implementation = _non_module_deps_impl)

modules/opentelemetry-cpp/1.14.2/source.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44
"url": "https://github.com/open-telemetry/opentelemetry-cpp/archive/refs/tags/v1.14.2.tar.gz",
55
"patch_strip": 1,
66
"patches": {
7-
"0001-Add-MODULE.bazel.patch": "sha256-d/1VjVoP5o4qty3iB5kIdP52QkPquFtUoIB9UJQHu2o="
7+
"0001-Add-MODULE.bazel.patch": "sha256-ii7+OaxMYnaGn2Y6El5fHy2OCnKlx6wxn1YGX09/bBU="
88
}
99
}

0 commit comments

Comments
 (0)