Skip to content

[Bug]: zstd_cli does not have parallelism enabled #3367

Open
@gergondet-woven

Description

@gergondet-woven

What happened?

When using zstd_cli from the registry module, it appears threading options are disabled.

For example:

bazel run @zstd//:zstd_cli -- --help

Does not show help for the -T# option or other threading related options. Compressing with -T0 does not affect the compression performances.

Version

Development (host) and target OS/architectures: Linux / x86_64

Output of bazel --version: bazel 7.4.0

Version of relevant rules from the WORKSPACE or MODULE.bazel file: bazel_dep(name = "zstd", version = "1.5.6", dev_dependency = True)

Language(s) and/or frameworks involved: N/A

How to reproduce

No response

Any other information?

I believe this can be fixed by adding local_defines = [ "ZSTD_MULTITHREAD" ] to the zstd_cli rule: https://github.com/bazelbuild/bazel-central-registry/blob/main/modules/zstd/1.5.6/patches/add_build_file.patch#L77

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions