Propagate runfiles from deps in cc_shared_library

fmeum · fmeum · commit 51befd587dfc · 2025-05-06T16:31:37.000+02:00
diff --git a/src/main/starlark/builtins_bzl/common/cc/cc_shared_library.bzl b/src/main/starlark/builtins_bzl/common/cc/cc_shared_library.bzl
@@ -749,6 +749,8 @@ def _cc_shared_library_impl(ctx):
     )
     for dep in ctx.attr.dynamic_deps:
         runfiles = runfiles.merge(dep[DefaultInfo].data_runfiles)
+    for dep in ctx.attr.deps:
+        runfiles = runfiles.merge(dep[DefaultInfo].data_runfiles)
 
     precompiled_only_dynamic_libraries_runfiles = []
     for precompiled_dynamic_library in precompiled_only_dynamic_libraries:

Original file line number	Diff line number	Diff line change
`@@ -749,6 +749,8 @@ def _cc_shared_library_impl(ctx):`
`749`	`749`	`)`
`750`	`750`	`for dep in ctx.attr.dynamic_deps:`
`751`	`751`	`runfiles = runfiles.merge(dep[DefaultInfo].data_runfiles)`
	`752`	`+ for dep in ctx.attr.deps:`
	`753`	`+ runfiles = runfiles.merge(dep[DefaultInfo].data_runfiles)`
`752`	`754`
`753`	`755`	`precompiled_only_dynamic_libraries_runfiles = []`
`754`	`756`	`for precompiled_dynamic_library in precompiled_only_dynamic_libraries:`