Fix //src/test/shell/bazel:srcs_test

This test has been failing since we switched to Bzlmod, therefore the top level `//:srcs` target doesn't contain all Bazel source files anymore. This PR fixes the tests and all relevant BUILD file to restore the correct state.

Closes #26141.

PiperOrigin-RevId: 765106541
Change-Id: Ib8f0ac643e0f613fe9e2e6a9e330c224829c23c7

Author: meteorcloudy

BUILD

@@ -30,7 +30,6 @@ filegroup(
     srcs = glob(
         ["*"],
         exclude = [
-            "MODULE.bazel.lock",  # Use MODULE.bazel.lock.dist instead
             "bazel-*",  # convenience symlinks
             "out",  # IntelliJ with setup-intellij.sh
             "output",  # output of compile.sh
@@ -164,6 +163,7 @@ pkg_files(
     srcs = ["//:srcs"],
     attributes = pkg_attributes(mode = "0755"),
     excludes = [
+        "MODULE.bazel.lock",  # Use MODULE.bazel.lock.dist instead
         "//examples:srcs",
         "//site:srcs",
         "//src:srcs-to-exclude-in-distfile",

src/BUILD

@@ -388,6 +388,7 @@ filegroup(
         "//src/main/protobuf:srcs",
         "//src/main/res:srcs",
         "//src/main/starlark/builtins_bzl:srcs",
+        "//src/main/starlark/docgen:srcs",
         "//src/main/tools:srcs",
         "//src/test/cpp:srcs",
         "//src/test/gen:srcs",
@@ -406,6 +407,7 @@ filegroup(
         "//src/test/tools:srcs",
         "//src/test/tools/bzlmod:srcs",
         "//src/test/tools/test_repos:srcs",
+        "//src/tools/android:srcs",
         "//src/tools/bzlmod:srcs",
         "//src/tools/diskcache:srcs",
         "//src/tools/execlog:srcs",

src/java_tools/buildjar/java/com/google/devtools/build/java/turbine/BUILD

@@ -10,6 +10,12 @@ package(
 
 licenses(["notice"])
 
+filegroup(
+    name = "srcs",
+    srcs = glob(["**"]),
+    visibility = ["//src:__subpackages__"],
+)
+
 _TURBINE_MAIN_CLASS = "com.google.turbine.main.Main"
 
 java_library(
@@ -155,13 +161,3 @@ sh_binary(
     name = "update_turbine_pgo",
     srcs = ["update_turbine_pgo.sh"],
 )
-
-filegroup(
-    name = "srcs",
-    srcs = glob(
-        ["**/*.java"],
-        allow_empty = True,
-    ) + [
-        "BUILD",
-    ],
-)

src/java_tools/import_deps_checker/javatests/com/google/devtools/build/importdeps/testdata/BUILD

@@ -12,7 +12,9 @@ licenses(["notice"])  # Apache 2.0
 filegroup(
     name = "srcs",
     testonly = False,
-    srcs = glob(["**"]),
+    srcs = glob(["**"]) + [
+        "//src/java_tools/import_deps_checker/javatests/com/google/devtools/build/importdeps/testdata/j_p_l:srcs",
+    ],
 )
 
 java_library(

src/java_tools/import_deps_checker/javatests/com/google/devtools/build/importdeps/testdata/j_p_l/BUILD

@@ -8,6 +8,13 @@ package(
     default_visibility = ["//src/java_tools/import_deps_checker/javatests/com/google/devtools/build/importdeps:__subpackages__"],
 )
 
+filegroup(
+    name = "srcs",
+    testonly = False,
+    srcs = glob(["**"]),
+    visibility = ["//src:__subpackages__"],
+)
+
 java_library(
     name = "a",
     srcs = ["A.java"],

src/main/protobuf/BUILD

@@ -418,7 +418,9 @@ java_library_srcs(
 
 filegroup(
     name = "srcs",
-    srcs = glob(["**"]),
+    srcs = glob(["**"]) + [
+        "//src/main/protobuf/project:srcs",
+    ],
 )
 
 filegroup(

src/main/protobuf/project/BUILD

@@ -6,6 +6,12 @@ package(
     default_visibility = ["//visibility:private"],
 )
 
+filegroup(
+    name = "srcs",
+    srcs = glob(["**"]),
+    visibility = ["//src:__subpackages__"],
+)
+
 filegroup(
     name = "project_proto_scl",
     srcs = ["project_proto.scl"],

src/main/starlark/docgen/BUILD

@@ -3,6 +3,12 @@ package(
     default_visibility = ["//src:__subpackages__"],
 )
 
+filegroup(
+    name = "srcs",
+    srcs = glob(["**"]),
+    visibility = ["//src:__subpackages__"],
+)
+
 # This rule is only available from Bazel 7.0.0
 starlark_doc_extract(
     name = "gen_be_proto_stardoc_proto",

src/test/java/com/google/devtools/build/lib/BUILD

@@ -31,6 +31,7 @@ filegroup(
         "//src/test/java/com/google/devtools/build/lib/generatedprojecttest:srcs",
         "//src/test/java/com/google/devtools/build/lib/generatedprojecttest/util:srcs",
         "//src/test/java/com/google/devtools/build/lib/graph:srcs",
+        "//src/test/java/com/google/devtools/build/lib/includescanning:srcs",
         "//src/test/java/com/google/devtools/build/lib/integration/util:srcs",
         "//src/test/java/com/google/devtools/build/lib/io:srcs",
         "//src/test/java/com/google/devtools/build/lib/metrics:srcs",
@@ -46,14 +47,17 @@ filegroup(
         "//src/test/java/com/google/devtools/build/lib/query2:srcs",
         "//src/test/java/com/google/devtools/build/lib/remote:srcs",
         "//src/test/java/com/google/devtools/build/lib/rules:srcs",
+        "//src/test/java/com/google/devtools/build/lib/runtime:srcs",
         "//src/test/java/com/google/devtools/build/lib/sandbox:srcs",
         "//src/test/java/com/google/devtools/build/lib/server:srcs",
         "//src/test/java/com/google/devtools/build/lib/skyframe:srcs",
         "//src/test/java/com/google/devtools/build/lib/skyframe/packages:srcs",
         "//src/test/java/com/google/devtools/build/lib/skyframe/serialization:srcs",
         "//src/test/java/com/google/devtools/build/lib/standalone:srcs",
         "//src/test/java/com/google/devtools/build/lib/starlark:srcs",
+        "//src/test/java/com/google/devtools/build/lib/starlarkbuildapi/core:srcs",
         "//src/test/java/com/google/devtools/build/lib/starlarkdebug/server:srcs",
+        "//src/test/java/com/google/devtools/build/lib/starlarkdocextract:srcs",
         "//src/test/java/com/google/devtools/build/lib/supplier:srcs",
         "//src/test/java/com/google/devtools/build/lib/testing/common:srcs",
         "//src/test/java/com/google/devtools/build/lib/testutil:srcs",

src/test/java/com/google/devtools/build/lib/includescanning/BUILD

@@ -5,6 +5,12 @@ package(
     default_visibility = ["//src:__subpackages__"],
 )
 
+filegroup(
+    name = "srcs",
+    srcs = glob(["**"]),
+    visibility = ["//src:__subpackages__"],
+)
+
 java_test(
     name = "CppIncludeScanningContextImplTest",
     size = "small",

src/test/java/com/google/devtools/build/lib/rules/BUILD

@@ -10,6 +10,7 @@ filegroup(
     name = "srcs",
     testonly = 0,
     srcs = glob(["*"]) + [
+        "//src/test/java/com/google/devtools/build/lib/rules/android:srcs",
         "//src/test/java/com/google/devtools/build/lib/rules/apple:srcs",
         "//src/test/java/com/google/devtools/build/lib/rules/config:srcs",
         "//src/test/java/com/google/devtools/build/lib/rules/cpp:srcs",

src/test/java/com/google/devtools/build/lib/runtime/BUILD

@@ -6,6 +6,15 @@ package(
     default_visibility = ["//src:__subpackages__"],
 )
 
+filegroup(
+    name = "srcs",
+    testonly = 0,
+    srcs = glob(["**"]) + [
+        "//src/test/java/com/google/devtools/build/lib/runtime/commands/info:srcs",
+    ],
+    visibility = ["//src:__subpackages__"],
+)
+
 java_library(
     name = "RuntimeTests_lib",
     srcs = glob(

src/test/java/com/google/devtools/build/lib/runtime/commands/info/BUILD

@@ -6,6 +6,13 @@ package(
     default_visibility = ["//src:__subpackages__"],
 )
 
+filegroup(
+    name = "srcs",
+    testonly = 0,
+    srcs = glob(["**"]),
+    visibility = ["//src:__subpackages__"],
+)
+
 java_test(
     name = "StdoutInfoItemHandlerTest",
     size = "small",

src/test/java/com/google/devtools/build/lib/skyframe/serialization/BUILD

@@ -8,7 +8,11 @@ package(
 filegroup(
     name = "srcs",
     testonly = 0,
-    srcs = glob(["**"]),
+    srcs = glob(["**"]) + [
+        "//src/test/java/com/google/devtools/build/lib/skyframe/serialization/analysis:srcs",
+        "//src/test/java/com/google/devtools/build/lib/skyframe/serialization/strings:srcs",
+        "//src/test/java/com/google/devtools/build/lib/skyframe/serialization/testutils:srcs",
+    ],
     visibility = ["//src:__subpackages__"],
 )
 

src/test/java/com/google/devtools/build/lib/skyframe/serialization/analysis/BUILD

@@ -5,6 +5,12 @@ package(
     default_visibility = ["//src:__subpackages__"],
 )
 
+filegroup(
+    name = "srcs",
+    srcs = glob(["**"]),
+    visibility = ["//src:__subpackages__"],
+)
+
 java_test(
     name = "AnalysisCacheInvalidatorTest",
     srcs = ["AnalysisCacheInvalidatorTest.java"],

src/test/java/com/google/devtools/build/lib/starlarkbuildapi/core/BUILD

@@ -6,6 +6,13 @@ package(
     default_visibility = ["//src:__subpackages__"],
 )
 
+filegroup(
+    name = "srcs",
+    testonly = 0,
+    srcs = glob(["**"]),
+    visibility = ["//src:__subpackages__"],
+)
+
 java_test(
     name = "ContextGuardedValueTest",
     srcs = ["ContextGuardedValueTest.java"],

src/test/java/com/google/devtools/build/lib/util/BUILD

@@ -11,6 +11,7 @@ filegroup(
     testonly = 0,
     srcs = glob(["*"]) + [
         "//src/test/java/com/google/devtools/build/lib/util/io:srcs",
+        "//src/test/java/com/google/devtools/build/lib/util/regex:srcs",
         "//src/test/java/com/google/devtools/build/lib/util/subjects:srcs",
     ],
     visibility = ["//src:__subpackages__"],

src/test/java/com/google/devtools/build/lib/util/regex/BUILD

@@ -13,7 +13,7 @@ filegroup(
     name = "srcs",
     testonly = 0,
     srcs = glob(["**"]),
-    visibility = ["//visibility:private"],
+    visibility = ["//src:__subpackages__"],
 )
 
 java_test(

src/test/shell/bazel/BUILD

@@ -1240,6 +1240,7 @@ sh_test(
     srcs = ["srcs_test.sh"],
     data = [
         ":srcs_list",
+        "@bazel_tools//tools/bash/runfiles",
         "@local_bazel_source_list//:sources",
     ],
     tags = ["no_windows"],

src/test/shell/bazel/srcs_test.sh

@@ -18,20 +18,40 @@
 # Actually this test just compares the two input (the file list and the
 # //:srcs filegroup and show the diff)
 
-LIST_SRCS="${TEST_SRCDIR}/local_bazel_source_list/sources.txt"
+# --- begin runfiles.bash initialization ---
+# Copy-pasted from Bazel's Bash runfiles library (tools/bash/runfiles/runfiles.bash).
+set -euo pipefail
+if [[ ! -d "${RUNFILES_DIR:-/dev/null}" && ! -f "${RUNFILES_MANIFEST_FILE:-/dev/null}" ]]; then
+    if [[ -f "$0.runfiles_manifest" ]]; then
+      export RUNFILES_MANIFEST_FILE="$0.runfiles_manifest"
+    elif [[ -f "$0.runfiles/MANIFEST" ]]; then
+      export RUNFILES_MANIFEST_FILE="$0.runfiles/MANIFEST"
+    elif [[ -f "$0.runfiles/bazel_tools/tools/bash/runfiles/runfiles.bash" ]]; then
+      export RUNFILES_DIR="$0.runfiles"
+    fi
+fi
+if [[ -f "${RUNFILES_DIR:-/dev/null}/bazel_tools/tools/bash/runfiles/runfiles.bash" ]]; then
+  source "${RUNFILES_DIR}/bazel_tools/tools/bash/runfiles/runfiles.bash"
+elif [[ -f "${RUNFILES_MANIFEST_FILE:-/dev/null}" ]]; then
+  source "$(grep -m1 "^bazel_tools/tools/bash/runfiles/runfiles.bash " \
+            "$RUNFILES_MANIFEST_FILE" | cut -d ' ' -f 2-)"
+else
+  echo >&2 "ERROR: cannot find @bazel_tools//tools/bash/runfiles:runfiles.bash"
+  exit 1
+fi
+# --- end runfiles.bash initialization ---
+
+LIST_SRCS="$(rlocation "local_bazel_source_list/sources.txt")"
 SRCS_QUERY="$(mktemp)"
 
-# Rewrite labels to file paths. This assumes any external repo is actually
-# a local_repository located in third_party.
-cat "${TEST_SRCDIR}/io_bazel/src/test/shell/bazel/srcs_list" \
-  | sed -e 's|@bazel_tools//||' \
-  | sed -e 's|@io_bazel//||' \
-  | sed -e 's|@\([^/]*\)//|third_party/\1|' \
+# Rewrite labels to file paths, ignoring all external repos.
+cat "$(rlocation "io_bazel/src/test/shell/bazel/srcs_list")" \
+  | sed -e '/^@@/d' \
   | sed -e 's|^//||' | sed -e 's|^:||' | sed -e 's|:|/|' \
   | sort -u >"${SRCS_QUERY}"
 
 res="$(diff -U 0 "${LIST_SRCS}" "${SRCS_QUERY}" | sed -e 's|^-||' \
-  | grep -Ev '^(@@|\+\+|--)' || true)"
+  | grep -Ev '^(@|\+|-)' || true)"
 
 if [ -n "${res}" ]; then
   echo "//:srcs filegroup do not contains all the sources, missing:

src/tools/android/BUILD

@@ -3,6 +3,11 @@ filegroup(
     srcs = [
         "BUILD",
         "maven_android_install.json",
+        "//src/tools/android/java/com/google/devtools/build/android:BUILD",
+        "//src/tools/android/java/com/google/devtools/build/android/dexer:BUILD",
+        "//src/tools/android/java/com/google/devtools/build/android/idlclass:BUILD",
+        "//src/tools/android/java/com/google/devtools/build/android/resources:BUILD",
+        "//src/tools/android/java/com/google/devtools/build/android/ziputils:BUILD",
     ],
     visibility = ["//src:__pkg__"],
 )

src/tools/android/java/com/google/devtools/build/android/BUILD

@@ -1 +1,2 @@
 # Empty migration placeholder
+exports_files(["BUILD"])

src/tools/android/java/com/google/devtools/build/android/dexer/BUILD

@@ -1 +1,2 @@
 # Empty migration placeholder
+exports_files(["BUILD"])

src/tools/android/java/com/google/devtools/build/android/idlclass/BUILD

@@ -1 +1,2 @@
 # Empty migration placeholder
+exports_files(["BUILD"])

src/tools/android/java/com/google/devtools/build/android/r8/BUILD

@@ -1 +1,2 @@
 # Empty migration placeholder
+exports_files(["BUILD"])

src/tools/android/java/com/google/devtools/build/android/resources/BUILD

@@ -1 +1,2 @@
 # Empty migration placeholder
+exports_files(["BUILD"])

src/tools/android/java/com/google/devtools/build/android/ziputils/BUILD

@@ -20,6 +20,7 @@ filegroup(
         "//third_party/java/jcommander:srcs",
         "//third_party/java/proguard:srcs",
         "//third_party/pprof:srcs",
+        "//third_party/proguard:srcs",
         "//third_party/protobuf:srcs",
         "//third_party/py/abseil:srcs",
         "//third_party/py/concurrent:srcs",

third_party/BUILD

@@ -1,6 +1,12 @@
 load("@rules_java//java:java_binary.bzl", "java_binary")
 load("@rules_java//java:java_import.bzl", "java_import")
 
+filegroup(
+    name = "srcs",
+    srcs = glob(["**"]),
+    visibility = ["//third_party:__subpackages__"],
+)
+
 java_binary(
     name = "proguard",
     main_class = "proguard.ProGuard",