incompatible_repo_env_ignores_action_env

[Silic0nS0ldier]

Motivation

Address a counterintuitive interaction with --action_env and it's affect on repository environments.

Note that this will implicitly affect other features which inherit the repository environment such as;

• Credential managers
• Download manager

And possibly more.

Description

Stops --action_env=NAME=VALUE from contributing to the repository environment, matching--action_env=NAME behaviour (only affecting action environments).

Incompatible Flag

--incompatible_repo_env_ignores_action_env

Migration Guide

For any existing usage of --action_env=NAME=VALUE, add --repo_env=NAME=VALUE.

This will keep the repository environment the same when --incompatible_repo_env_ignores_action_env is enabled.

In which Bazel LTS version will this incompatible change be enabled?

None

Additional Context

Merged into v9 development branch with #25238.
Merging into v8.3 development branch with #26221.

TODO List

• Implement the incompatible change at Bazel HEAD and guard it behind a flag.
• Backport the incompatible flag to the latest LTS release. ([8.3.0] Add --incompatible_repo_env_ignores_action_env option #26221)
• Test the incompatible change with downstream projects and inform broken projects.
• Flip the incompatible flag at Bazel HEAD. (Flip --incompatible_repo_env_ignores_action_env #26489)
• Delete the incompatible flag and the old behavior at Bazel HEAD. (Deprecate --incompatible_repo_env_ignores_action_env #27745)

[Silic0nS0ldier]

@iancha1992 @meteorcloudy Since I'm not a core contributor, I don't have the access necessary to run the "Bazelisk + Incompatible flags" pipeline.

Can someone run it with INCOMPATIBLE_FLAGS=--incompatible_repo_env_ignores_action_env on my behalf?

[meteorcloudy]

Started a build here: https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1812