Clarify the invalidation of REPO_CONTENTS_CACHE_DIRS FileStateValues #28222
+88
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-ExternalDeps
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several valuable improvements. It clarifies the invalidation logic for REPO_CONTENTS_CACHE_DIRS by making an implicit assumption explicit with a fail-fast exception. It also fixes a crash when an invalid repository rule is referenced by a target, and adds a new test to cover this scenario. Furthermore, the test coverage for the repository contents cache is significantly improved by verifying file contents, not just caching behavior. Finally, the update to the test infrastructure to provide real-time process output is a great quality-of-life improvement for developers. The changes are well-structured and look good.
Along the way, improve the test coverage for repo contents cache deletion by asserting that non-BUILD files within it actually exist on disk rather than just exist from the point of Skyframe. Also fix a crash observed while working on the test improvements.
fmeum
added
the
soft-release-blocker
Collaborator
Author
|
@bazel-io fork 9.0.0 |
Wyverald
reviewed
Jan 10, 2026
src/main/java/com/google/devtools/build/lib/skyframe/ExternalFilesHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/skyframe/ExternalFilesHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/skyframe/ExternalFilesHelper.java
Outdated
Show resolved
Hide resolved
fmeum
removed
the
soft-release-blocker
Wyverald
approved these changes
Jan 10, 2026
Wyverald
approved these changes
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this behavior is quite surprising (it definitely was to the author), this change also improves the test coverage for repo contents cache deletion by asserting that non-BUILD files within it actually exist on disk rather than just exist from the point of Skyframe.
Also fix a crash observed while working on the test improvements.