-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Closed
Labels
incompatible-changeIncompatible/breaking changeIncompatible/breaking changeteam-Configurabilityplatforms, toolchains, cquery, select(), config transitionsplatforms, toolchains, cquery, select(), config transitionsteam-CoreSkyframe, bazel query, BEP, options parsing, bazelrcSkyframe, bazel query, BEP, options parsing, bazelrctype: processuntriaged
Description
Motivation
Only test and testonly targets are exempted from the test trimming transition, which means that non-testonly targets with dependencies on tests can result in highly unexpected action conflicts. Flipping this flag fixes the remaining loophole that permits this.
Description
Targets that aren't tests but depend on test rule's output files now have to be marked testonly, just like any such target that directly depends on a test rule.
Incompatible Flag
--incompatible_check_testonly_for_output_files
Migration Guide
Add testonly = True or remove the dependency.
In which Bazel LTS version will this incompatible change be enabled?
Bazel 10
Additional Context
TODO List
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
incompatible-changeIncompatible/breaking changeIncompatible/breaking changeteam-Configurabilityplatforms, toolchains, cquery, select(), config transitionsplatforms, toolchains, cquery, select(), config transitionsteam-CoreSkyframe, bazel query, BEP, options parsing, bazelrcSkyframe, bazel query, BEP, options parsing, bazelrctype: processuntriaged