buildozer: refactor the glob handling to a special case

Author: stagnation

buildozer/buildozer_test.sh

@@ -1953,6 +1953,14 @@ function test_set_config_string() {
 )'
 }
 
+function test_set_glob_srcs() {
+  run "$no_deps" 'set srcs glob(["*.go"])' '//pkg:edit'
+  assert_equals 'go_library(
+    name = "edit",
+    srcs = glob(["*.go"]),
+)'
+}
+
 function test_fix_unused_load() {
   run 'load(":a.bzl", "a")
 # TODO: refactor

edit/buildozer.go

@@ -585,7 +585,10 @@ func getAttrValueExpr(attr string, args []string, env CmdEnvironment) build.Expr
 			list = append(list, &build.LiteralExpr{Token: i})
 		}
 		return &build.ListExpr{List: list}
-	case IsList(attr) && !(len(args) == 1 && strings.HasPrefix(args[0], "glob(")):
+	case IsList(attr) && len(args) == 1 && strings.HasPrefix(args[0], "glob("):
+		// Single-value glob
+		return &build.Ident{Name: args[0]}
+	case IsList(attr):
 		var list []build.Expr
 		for _, arg := range args {
 			list = append(list, getStringExpr(arg, env.Pkg))