Skip to content

Commit 97a904e

Browse files
authored
Fix collecting already failing jobs (#2208)
1 parent fe07a62 commit 97a904e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

buildkite/aggregate_incompatible_flags_test_result.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ def process_build_log(failed_jobs_per_flag, already_failing_jobs, log, job):
6969

7070
if "Failure: Command failed, even without incompatible flags." in log:
7171
already_failing_jobs.append(job)
72+
return
7273

7374
def handle_failing_flags(line):
7475
flag = extract_flag(line)
@@ -93,7 +94,7 @@ def handle_failing_flags(line):
9394
log = log[0 : log.rfind("+++ Result")]
9495

9596
# If no "+++ Result" was found, the job must have failed for other reasons
96-
if not found_result:
97+
if job["state"] == "failed" and not found_result:
9798
already_failing_jobs.append(job)
9899

99100

0 commit comments

Comments
 (0)