BCR PR reviewer: notify BCR maintainers on modules with metadata only changes (#2213)

Author: meteorcloudy

actions/bcr-pr-reviewer/index.js

@@ -1,7 +1,7 @@
 const { getInput, setFailed } = require('@actions/core');
 const { context, getOctokit } = require("@actions/github");
 
-async function fetchAllModifiedModules(octokit, owner, repo, prNumber) {
+async function fetchAllModifiedModuleVersions(octokit, owner, repo, prNumber) {
   let page = 1;
   const perPage = 100; // GitHub's max per_page value
   let accumulate = new Set();
@@ -29,6 +29,34 @@ async function fetchAllModifiedModules(octokit, owner, repo, prNumber) {
   return accumulate;
 }
 
+async function fetchAllModulesWithMetadataChange(octokit, owner, repo, prNumber) {
+  let page = 1;
+  const perPage = 100; // GitHub's max per_page value
+  let accumulate = new Set();
+  let response;
+
+  do {
+    response = await octokit.rest.pulls.listFiles({
+      owner,
+      repo,
+      pull_number: prNumber,
+      per_page: perPage,
+      page,
+    });
+
+    response.data.forEach(file => {
+      const match = file.filename.match(/^modules\/([^\/]+)\/metadata\.json/);
+      if (match) {
+        accumulate.add(match[1]);
+      }
+    });
+
+    page++;
+  } while (response.data.length === perPage);
+
+  return accumulate;
+}
+
 async function generateMaintainersMap(octokit, owner, repo, modifiedModules, toNotifyOnly) {
   const maintainersMap = new Map(); // Map: maintainer GitHub username -> Set of module they maintain
   const modulesWithoutGithubMaintainers = new Set(); // Set of module names without module maintainers
@@ -263,7 +291,7 @@ async function reviewPR(octokit, owner, repo, prNumber) {
   }
 
   // Fetch modified modules
-  const modifiedModuleVersions = await fetchAllModifiedModules(octokit, owner, repo, prNumber);
+  const modifiedModuleVersions = await fetchAllModifiedModuleVersions(octokit, owner, repo, prNumber);
   const modifiedModules = new Set(Array.from(modifiedModuleVersions).map(module => module.split('@')[0]));
   console.log(`Modified modules: ${Array.from(modifiedModules).join(', ')}`);
   if (modifiedModules.size === 0) {
@@ -354,7 +382,7 @@ async function runNotifier(octokit) {
   const { owner, repo } = context.repo;
 
   // Fetch modified modules
-  const modifiedModuleVersions = await fetchAllModifiedModules(octokit, owner, repo, prNumber);
+  const modifiedModuleVersions = await fetchAllModifiedModuleVersions(octokit, owner, repo, prNumber);
   const modifiedModules = new Set(Array.from(modifiedModuleVersions).map(module => module.split('@')[0]));
   console.log(`Modified modules: ${Array.from(modifiedModules).join(', ')}`);
 
@@ -372,6 +400,20 @@ async function runNotifier(octokit) {
       `Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (${modulesList}) have been updated in this PR.
       Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.`);
   }
+
+  // Notify BCR maintainers for modules with only metadata.json changes
+  const allModulesWithMetadataChange = await fetchAllModulesWithMetadataChange(octokit, owner, repo, prNumber);
+  const modulesWithOnlyMetadataChanges = new Set(
+    [...allModulesWithMetadataChange].filter(module => !modifiedModules.has(module))
+  );
+
+  if (modulesWithOnlyMetadataChanges.size > 0) {
+    const modulesList = Array.from(modulesWithOnlyMetadataChanges).join(', ');
+    console.log(`Notifying @bazelbuild/bcr-maintainers for modules with only metadata.json changes: ${modulesList}`);
+    await postComment(octokit, owner, repo, prNumber,
+      `Hello @bazelbuild/bcr-maintainers, modules with only metadata.json changes (${modulesList}) have been updated in this PR.
+      Please review the changes.`);
+  }
 }
 
 async function waitForDismissApprovalsWorkflow(octokit, owner, repo) {
@@ -516,7 +558,7 @@ async function runDiffModule(octokit) {
   const { owner, repo } = context.repo;
 
   // Fetch modified modules
-  const modifiedModuleVersions = await fetchAllModifiedModules(octokit, owner, repo, prNumber);
+  const modifiedModuleVersions = await fetchAllModifiedModuleVersions(octokit, owner, repo, prNumber);
   console.log(`Modified modules: ${Array.from(modifiedModuleVersions).join(', ')}`);
 
   // Use group if more than one module are modified