Skip to content

Commit ae6975d

Browse files
committed
fixed toolchain resolution with the new aspect
1 parent 7fd3468 commit ae6975d

1 file changed

Lines changed: 14 additions & 10 deletions

File tree

cpp/src/com/google/idea/blaze/cpp/BlazeConfigurationToolchainResolver.java

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,12 @@
2020
import static java.util.stream.Collectors.joining;
2121

2222
import com.google.common.annotations.VisibleForTesting;
23-
import com.google.common.base.Joiner;
24-
import com.google.common.collect.ArrayListMultimap;
2523
import com.google.common.collect.ImmutableCollection;
26-
import com.google.common.collect.ImmutableList;
2724
import com.google.common.collect.ImmutableMap;
2825
import com.google.common.collect.Iterables;
29-
import com.google.common.collect.ListMultimap;
30-
import com.google.common.collect.Multimap;
3126
import com.google.common.util.concurrent.Futures;
3227
import com.google.common.util.concurrent.ListenableFuture;
28+
import com.google.devtools.intellij.ideinfo.IntellijIdeInfo.Dependency.DependencyType;
3329
import com.google.idea.blaze.base.async.executor.BlazeExecutor;
3430
import com.google.idea.blaze.base.ideinfo.CToolchainIdeInfo;
3531
import com.google.idea.blaze.base.ideinfo.Dependency;
@@ -49,15 +45,13 @@
4945
import com.google.idea.blaze.base.sync.workspace.ExecutionRootPathResolver;
5046
import com.google.idea.blaze.cpp.CompilerVersionChecker.VersionCheckException;
5147
import com.google.idea.blaze.cpp.XcodeCompilerSettingsProvider.XcodeCompilerSettingsException;
52-
import com.intellij.openapi.diagnostic.Logger;
5348
import com.intellij.openapi.project.Project;
5449
import com.intellij.openapi.util.SystemInfo;
5550
import com.intellij.pom.NavigatableAdapter;
5651

5752
import java.io.File;
5853
import java.util.AbstractMap.SimpleImmutableEntry;
5954
import java.util.ArrayList;
60-
import java.util.Collection;
6155
import java.util.HashSet;
6256
import java.util.List;
6357
import java.util.Map;
@@ -66,7 +60,6 @@
6660
import java.util.Set;
6761
import java.util.concurrent.Callable;
6862
import java.util.concurrent.ExecutionException;
69-
import java.util.stream.Collectors;
7063
import javax.annotation.Nullable;
7164

7265
/**
@@ -107,12 +100,23 @@ private static ImmutableMap<TargetIdeInfo, List<TargetKey>> buildToolchainDepsTa
107100
continue;
108101
}
109102

110-
final var toolchainDeps = target.getDependencies().stream()
103+
final var toolchain = target.getDependencies().stream()
104+
.filter(it -> it.getDependencyType() == DependencyType.TOOLCHAIN)
105+
.map(Dependency::getTargetKey)
106+
.filter(toolchains::containsKey)
107+
.findFirst();
108+
109+
if (toolchain.isPresent()) {
110+
toolchainDepsTable.put(target, List.of(toolchain.get()));
111+
continue;
112+
}
113+
114+
final var candidates = target.getDependencies().stream()
111115
.map(Dependency::getTargetKey)
112116
.filter(toolchains::containsKey)
113117
.collect(toImmutableList());
114118

115-
toolchainDepsTable.put(target, toolchainDeps);
119+
toolchainDepsTable.put(target, candidates);
116120
}
117121

118122
return toolchainDepsTable.build();

0 commit comments

Comments
 (0)